Update MaterialResourceHandle for variable-size color tables used since 7.0 #1545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
breaking change
Breaking ChangesType exists in left but not in rightFFXIVClientStructs.FFXIV.Client.System.Resource.Handle: 1MaterialResourceHandle: 2
Member exists in left but not in rightFFXIVClientStructs.FFXIV.Client.System.Resource.Handle: 1MaterialResourceHandle: 5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 7.0, most color tables are 8x32 (32 rows of 8 vectors of 2
Halfs, i. e. 2048 bytes) but some legacy ones are still 4x16 (512 bytes), making these structures and accessors very wrong since then.On top of the things being variable-size, a lot of the columns also have variable semantics (which depend on the exact shader set picked by a material), making it hard to do better than providing spans of
Halfs for the color table and ofbytes for the stain table and letting the callers cross-reference with shaders.