Conformance documentation mm #1335
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mark url item type as fully implemented (was partial) - Mark quantity item type as fully implemented (was partial) - Mark minQuantity constraint as supported - Mark maxQuantity constraint as supported Based on codebase analysis showing complete implementations with dedicated components, validation, and UI support. Closes #1325
✅ Added missing minQuantity and maxQuantity stories to SDC/BehaviorValueConstraints ✅ Combined redundant stories to save Chromatic quota: - Boolean: Combined BooleanBasic + BooleanBasicResponse → BooleanCombined - String: Combined StringBasic + StringBasicResponse → StringCombined - Integer: Combined IntegerBasic + IntegerBasicResponse → IntegerCombined ✅ Enhanced URL stories to show validation and multiple states ✅ Created new questionnaire assets with combined examples showing empty/filled states This addresses conformance document updates where url and quantity are now fully implemented ([x]) and adds comprehensive Storybook coverage for minQuantity/maxQuantity constraints.
…traints - Issue #1324 Step 3
fongsean
reviewed
Aug 4, 2025
| @@ -17,12 +17,12 @@ The list can be found here: http://hl7.org/fhir/R4/valueset-item-type.html | |||
| - [x] time | |||
| - [x] string | |||
| - [x] text | |||
| - [ ] url (partial implementation - using string UI component currently) | |||
| - [x] url | |||
There was a problem hiding this comment.
We still don't have a "real" working URL - it's still a partial implementation using the string UI component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1325 - Conformance Document Updates (9f9eacf)
Updated Conformance.md based on comprehensive codebase analysis:
✅ URL item type: Changed from [ ] to [x] - Found complete UrlItem component with full validation
✅ Quantity item type: Changed from [ ] to [x] - Found complete QuantityItem component implementation
✅ minQuantity constraint: Changed from [ ] to [x] - Found complete validation and UI support
✅ maxQuantity constraint: Changed from [ ] to [x] - Found complete validation and UI support