Skip to content

PocketMine-MP invalid skin geometry JSON data leading to server crash

High severity GitHub Reviewed Published Aug 16, 2022 in pmmp/PocketMine-MP • Updated Jan 7, 2023

Package

composer pocketmine/pocketmine-mp (Composer)

Affected versions

< 4.7.2

Patched versions

4.7.2

Description

Impact

pocketmine\entity\Skin doesn't correctly handle errors produced by adhocore/json-comment, which throws RuntimeException rather than returning false as PocketMine-MP expects.

This leads to a server crash if the skin geometry data is invalid for some reason (e.g. a syntax error).

Patches

c9626c610b8f6810c8c987559c9197b2a291f0bb

Workarounds

A plugin could handle LoginPacket and PlayerSkinPacket to verify the skin geometry data can be parsed correctly, so that the error condition in the core code is never reached.

For more information

If you have any questions or comments about this advisory:

References

@dktapps dktapps published to pmmp/PocketMine-MP Aug 16, 2022
Published to the GitHub Advisory Database Aug 18, 2022
Reviewed Aug 18, 2022
Last updated Jan 7, 2023

Severity

High

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v3 base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
None
Integrity
None
Availability
High

CVSS v3 base metrics

Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H

EPSS score

Weaknesses

No CWEs

CVE ID

No known CVE

GHSA ID

GHSA-8cwq-4cmf-px73

Source code

Loading Checking history
See something to contribute? Suggest improvements for this vulnerability.