Skip to content

Scix 650 abstract searchbar#785

Merged
thostetler merged 4 commits intoadsabs:masterfrom
shinyichen:SCIX-650-abstract-searchbar
Jan 30, 2026
Merged

Scix 650 abstract searchbar#785
thostetler merged 4 commits intoadsabs:masterfrom
shinyichen:SCIX-650-abstract-searchbar

Conversation

@shinyichen
Copy link
Member

Add search bar to abstract.

Screenshot 2026-01-27 at 4 37 31 PM

@shinyichen shinyichen requested a review from thostetler January 28, 2026 00:37
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.2%. Comparing base (664e1c4) to head (a093759).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/components/SearchBar/SearchBar.tsx 25.0% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #785     +/-   ##
========================================
+ Coverage    61.1%   61.2%   +0.1%     
========================================
  Files         304     306      +2     
  Lines       35318   35410     +92     
  Branches     1534    1534             
========================================
+ Hits        21567   21657     +90     
- Misses      13715   13717      +2     
  Partials       36      36             
Files with missing lines Coverage Δ
src/components/AbstractSideNav/AbstractSideNav.tsx 95.9% <100.0%> (-0.1%) ⬇️
src/components/SearchBar/SearchBar.tsx 67.2% <25.0%> (-11.8%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@thostetler thostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look pretty good to me, one thing I noticed is that the search bar does not maintain the query when you select an abstract to view. Is this intentional?


return (
<form method="get" action="/search" onSubmit={handleOnSubmit}>
<SearchBar showBackLinkAs="results" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be inserting the current query here? you can get it from the global store.

Unless we just want to keep the search bar here for new queries users may make

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thostetler Hmm, I'm not sure which makes more sense. Let me check with Kelly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thostetler I've added in the query. Can you help me check if I'm doing it correctly?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should work okay, yeah 👍

@shinyichen shinyichen force-pushed the SCIX-650-abstract-searchbar branch from 220635a to a093759 Compare January 29, 2026 17:56
@thostetler thostetler merged commit 0bbc033 into adsabs:master Jan 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants