Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #785 +/- ##
========================================
+ Coverage 61.1% 61.2% +0.1%
========================================
Files 304 306 +2
Lines 35318 35410 +92
Branches 1534 1534
========================================
+ Hits 21567 21657 +90
- Misses 13715 13717 +2
Partials 36 36
🚀 New features to boost your workflow:
|
thostetler
left a comment
There was a problem hiding this comment.
Changes look pretty good to me, one thing I noticed is that the search bar does not maintain the query when you select an abstract to view. Is this intentional?
|
|
||
| return ( | ||
| <form method="get" action="/search" onSubmit={handleOnSubmit}> | ||
| <SearchBar showBackLinkAs="results" /> |
There was a problem hiding this comment.
Should we be inserting the current query here? you can get it from the global store.
Unless we just want to keep the search bar here for new queries users may make
There was a problem hiding this comment.
@thostetler Hmm, I'm not sure which makes more sense. Let me check with Kelly.
There was a problem hiding this comment.
@thostetler I've added in the query. Can you help me check if I'm doing it correctly?
There was a problem hiding this comment.
I think this should work okay, yeah 👍
220635a to
a093759
Compare
Add search bar to abstract.