SCIX-444 Prevent clicking non-ADS ORCID items#2367
Merged
thostetler merged 1 commit intoadsabs:masterfrom Dec 17, 2025
Merged
Conversation
thostetler
changed the title
shinyichen
reviewed
Dec 12, 2025
Comment on lines
+24
to
+26
| <a href="#abs/{{encodedIdentifier}}/abstract" data-item-index="{{indexToShow}}" aria-label="bibcode" class="abs-redirect-link"> | ||
| {{identifier}} | ||
| </a> |
Member
There was a problem hiding this comment.
Is this section suppose to be different from lines 17-19?
Member
Author
There was a problem hiding this comment.
It's not different -- just makes the logic a little cleaner here since we section off the orcid widget items vs. regular list items.
We could combine the comparisons, do you think that would be a little cleaner vs. duplicating here?
shinyichen
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ORCiD page: If record is NOT known to ADS, then just show the record title (no link)