streamline dynamic machine label creation and cleanup process #6372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahdipub
force-pushed
the
EBC_pipeline_call
branch
from
3be7307 to
a2fcdeb
Compare
llxia
reviewed
Jun 27, 2025
llxia
reviewed
Jun 27, 2025
llxia
reviewed
Jun 27, 2025
| try { | ||
| timeout(time: 120, unit: 'MINUTES') { | ||
| // ToDo: pass in platform once we support more platforms. For now, we only support xlinux. | ||
| getEBCNode(ebcDemandId, dynamicMachineLabel) | ||
| def dynamicMachineLabel = 'ci.agent.dynamic.' + UUID.randomUUID().toString() | ||
| getEBCNode(dynamicMachineLabel) | ||
| node(dynamicMachineLabel) { | ||
| echo "EBC node ${dynamicMachineLabel} is ready" |
There was a problem hiding this comment.
Do we need to check for the node to be ready here? It appears that is what param WAIT is doing on the Create job.
There was a problem hiding this comment.
I would say it doesn't hurt if we keep it for when we decide to set wait:false.
mahdipub
force-pushed
the
EBC_pipeline_call
branch
from
a2fcdeb to
5e724bc
Compare
mahdipub
force-pushed
the
EBC_pipeline_call
branch
from
5e724bc to
ac8db10
Compare
AdamBrousseau
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses create/free EBC pipeline calls which lets manage EBC from central job.
Signed-off-by: [email protected]