Skip to content

exclude JDK8 ValidateISO4217 test #6179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

sxa
Copy link
Member

@sxa sxa commented Apr 11, 2025

If this needs to have an issue in here and not just a reference to the OpenJ9 one let me know.

This has been seen on the Temurin builds too and is potentially a date-related issue as per this comment . Excluded for OpenJ9 in #6126

We'll also need to cherry-pick this across to the release branch when approved.

Signed-off-by: Stewart X Addison <[email protected]>
@sxa sxa self-assigned this Apr 11, 2025
@sxa
Copy link
Member Author

sxa commented Apr 11, 2025

Upstream fix - so this may not be required: openjdk/jdk8u-dev#646

@gnu-andrew
Copy link

It's definitely time related. The culprit is:

CW=ANG;2025-04-01-04-00-00;XCG

and similar for SX. Unfortunately, the code in 8u which handles future currencies doesn't seem to have realised that this is no longer a future currency and so you get the IllegalArgumentException. We have a quick fix of just dumping the historical data which resolves the test. The long-term fix is to make the logic actually work as it should (https://bugs.openjdk.org/browse/JDK-8353579)

@smlambert
Copy link
Contributor

run aqa --sdk_resource nightly --build_list openjdk --target sanity.openjdk --jdk_version 8 --jdk_impl hotspot --platform x86-64_linux

@@ -361,6 +361,7 @@ com/sun/jdi/PrivateTransportTest.sh https://github.com/adoptium/aqa-tests/issues
# jdk_util

java/util/Arrays/TimSortStackSize2.java https://github.com/adoptium/aqa-tests/issues/1051 linux-s390x
java/util/Currency/ValidateISO4217.java https://github.com/eclipse-openj9/openj9/issues/21539 generic-all

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better problemlist this testcase in ProblemList_openjdk8-openj9.txt, becase this test run passed by openjdk8, it only failed runed by openj9?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants