Fix findSiblings and the target kept its prototype#175
Open
sapryniukt wants to merge 1 commit intoadopted-ember-addons:mainfrom
Open
Fix findSiblings and the target kept its prototype#175sapryniukt wants to merge 1 commit intoadopted-ember-addons:mainfrom
sapryniukt wants to merge 1 commit intoadopted-ember-addons:mainfrom
Conversation
3a43952 to
50a1dcb
Compare
50a1dcb to
fac131c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We ran into the issue of losing prototype and incorrect invocation of
setDeepwhen tried to change theEmberDataproperty in thechangeset.My
changesetlooked something like this:but after execution:
We got:
Looks like
findSiblingsworks well with POJO, but doesn't consider Class object.I proppose a simple solution to this by using
or
Also the tests that check and reproduce the issue have been added.