Refactor types to separate files ready for adding new changeset implementation#148
Open
BryanCrotaz wants to merge 2 commits intoadopted-ember-addons:mainfrom
Open
Refactor types to separate files ready for adding new changeset implementation#148BryanCrotaz wants to merge 2 commits intoadopted-ember-addons:mainfrom
BryanCrotaz wants to merge 2 commits intoadopted-ember-addons:mainfrom
Conversation
snewcomer
requested changes
Dec 8, 2021
Collaborator
snewcomer
left a comment
snewcomer
left a comment
There was a problem hiding this comment.
Thanks for the PR. This probably won't get merged unless there was a PR showing why this refactor makes sense (likely a branch off of this one that is also PR'd)
| "internalConsoleOptions": "neverOpen", | ||
| "port": 9229, | ||
| "type": "pwa-node" | ||
| } |
Author
There was a problem hiding this comment.
why not make it easy for contributors to quickly get debugging? No reason why other tools shouldn't also be supported with configs, but VSCode is one of the most popular IDEs
Author
Yes, that's the plan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just moving functions and classes into cleaner locations to simplify adding new changeset type