[MWPW-191877] - SR Firefox animations#5830
Open
DKos95 wants to merge 69 commits intosite-redesign-foundationfrom
Open
[MWPW-191877] - SR Firefox animations#5830DKos95 wants to merge 69 commits intosite-redesign-foundationfrom
DKos95 wants to merge 69 commits intosite-redesign-foundationfrom
Conversation
Contributor
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
DKos95
changed the title
zagi25
reviewed
Apr 20, 2026
| fsScrollTimer = setTimeout(() => { window.lenis.options.lerp = lerp; }, fsDelay); | ||
| } | ||
| }, { passive: true }); | ||
| if (!CSS.supports('animation-timeline: view()')) { |
Contributor
There was a problem hiding this comment.
Should we also check for reduced-motion here ?
| @@ -0,0 +1,553 @@ | |||
| const vh = window.innerHeight; | |||
Contributor
There was a problem hiding this comment.
This can change on resize right ?
Contributor
|
I noticed few issues when resizing the browser, animations work pretty well on first load, but after screen is resized they start to brake. Also I believe Screen.Recording.2026-04-20.at.17.48.24.movScreen.Recording.2026-04-20.at.17.51.08.mov
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR adds support for firefox animations until they implement scroll driven animations.
Plans to implement polyfil were abandoned because of bad performance in combination with lenis, while this approach gives us better performance and requires less code.
Performance was measured to be ~120fps on firefox
Resolves: MWPW-191877
PSI Test URLs:
Firefox Test URLs: