Centralize per-viewport content decoration for C2#5827
Open
overmyheadandbody wants to merge 1 commit intosite-redesign-foundationfrom
Open
Centralize per-viewport content decoration for C2#5827overmyheadandbody wants to merge 1 commit intosite-redesign-foundationfrom
overmyheadandbody wants to merge 1 commit intosite-redesign-foundationfrom
Conversation
Contributor
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
DKos95
approved these changes
Apr 17, 2026
Contributor
|
Looking good! Here's sample page where the first 2 explore-cards have a video on desktop and image on mobile. |
rgclayton
reviewed
Apr 17, 2026
| }; | ||
|
|
||
| setContent(); | ||
| mq.addEventListener('change', setContent); |
Contributor
There was a problem hiding this comment.
Any concerns about this listener never being cleared?
rgclayton
approved these changes
Apr 17, 2026
zagi25
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to centralize a method to decorate cross-viewport content, now that we're introducing standard authoring pattern. Blocks where this has already been applied: base-card, rich-content, explore-card. Blocks that might not currently align with the authoring pattern or more investigation is needed from responsible engineers: router-marquee (where each viewport has multiple slides), news (where we're not aware of a need to have per-viewport content; additionally, in the future its content might come from an external source), elastic-carousel (which also has a different authoring pattern at the moment).
The logic currently support both
mobileandmobile-viewportkeywords (same for tablet/desktop), until engineers and GWP align on using the latter, which is needed for the localization process.Test URLs: