Open
Conversation
Contributor
Contributor
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
Blainegunn
requested review from
Roycethan,
antonio-rmrz,
bozojovicic and
joaquinrivero
Roycethan
reviewed
Apr 10, 2026
Contributor
There was a problem hiding this comment.
- There's no enough padding above the CTAs added in Marquee , spacing added in doc is not helping , can you plz review ?
https://main--da-cc--adobecom.aem.page/fr/drafts/reuben/trial?milolibs=MWPW-191834&akamaiLocale=ca
bozojovicic
approved these changes
Apr 14, 2026
antonio-rmrz
approved these changes
Apr 17, 2026
yesil
reviewed
Apr 17, 2026
Contributor
yesil
left a comment
yesil
left a comment
There was a problem hiding this comment.
@Blainegunn I don't think adding explicit mas-field logic into milo blocks is the right direction.
Isn't possible to handle all decoration/init in merch-card-autoblock?
Per reviewer feedback, remove explicit mas-field event listener logic from hero-marquee, marquee, and notification blocks. Instead, handle button class inheritance centrally in merch-card-autoblock via applyBlockButtonClasses(), which copies button-* classes from sibling .con-button elements after checkReady. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…hero-marquee and marquee These were only introduced to support the mas-field loops (now handled in merch-card-autoblock), leaving the blocks unchanged from their original state. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
6 tasks
antonio-rmrz
approved these changes
Apr 20, 2026
Roycethan
reviewed
Apr 20, 2026
Contributor
There was a problem hiding this comment.
@Blainegunn Can you plz review these:
https://main--da-cc--adobecom.aem.page/fr/drafts/reuben/trial?maslibs=mwpw-191344&milolibs=MWPW-191834
- On first fresh launch of the site , the CTA styles are lost, refreshing then work: ( Launch above page in incognito window )
- The spacing added before the CTAs is not rendered in the first milo block resulting in CTAs getting closer to the text:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI Fixes for M@S Fields
Updates to support CTAs and Headings when used in various blocks
Resolves: MWPW-191834
Test URLs: