feat: Floodgate DA Updates and Fixes by chrischrischris · Pull Request #5763 · adobecom/milo

chrischrischris · 2026-04-02T20:26:17Z

Update to floodgate for DA.

Structure — Split floodgate.js; add floodgate-workflows.js and floodgate-render.js. Lit: org + email for access checks.
Config & access — Parse allAccessUsers, copyOnlyUsers, draftsAllowed, colors, promote-ignore sheet; evaluateFloodgateAccess (full / copy-only / drafts-only / blocked). Ignore empty promote-ignore rows; discard stale config if org/repo changes mid-fetch.
Paths — Wildcards, line-level invalid highlighting, AEM preview URL to repo path, reject -fg-* in source paths, sessionStorage for textarea, debounced access re-eval.
Workflows — Batched existence checks, promote-ignore from config + UI, confirmations for large jobs (>50) and destructive ops, cancel mid-run, retry includes preview/publish errors and normalizes FG to source paths.
Copy / promote — -fg-{color} (not hard-coded pink); search-replace uses selected color; Queue (max 100 concurrent) instead of fixed batches; options-object constructors; fix empty-path guard in copy.
HTTP / bulk actions — daFetch returns full Response on 401; preview/publish callbacks include original DA path.
UI / CSS — Tabbed flow, done summary with expandable errors, badge/list slug alignment for expand toggles, updated Floodgate + minor floodbox styles.
Tests — New floodgate.test.js; expanded floodgate-config.test.js; utils.test.js tweaks.

Config for floodgate is set in org/site/.milo/floodgate/config.json in the main repo.

Test URLs:
https://da.live/app/adobecom/milo/tools/floodgate?ref=da-floodgate

aem-code-sync · 2026-04-02T20:26:22Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

Re-sync branch

Commits

fb6c832 ✅ (latest)
9e717c3 ✅
c41dab4 ✅

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_accessInfoMessage'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 94 in c41dab4

expect(el._accessInfoMessage).to.equal('Drafts only');

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_accessBlocksFind'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 105 in c41dab4

expect(el._accessBlocksFind()).to.be.true;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_configLoading'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 109 in c41dab4

el._configLoading = true;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_accessBlocksFind'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 110 in c41dab4

expect(el._accessBlocksFind()).to.be.true;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_floodgateConfig'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 114 in c41dab4

el._floodgateConfig = {};

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_accessBlocksFind'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 115 in c41dab4

expect(el._accessBlocksFind()).to.be.true;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_floodgateConfig'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 120 in c41dab4

const FloodgateConfig = el._floodgateConfig.constructor;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_floodgateConfig'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 121 in c41dab4

el._floodgateConfig = Object.create(FloodgateConfig.prototype);

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_accessBlockScope'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 122 in c41dab4

el._accessBlockScope = 'all';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_accessBlocksFind'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 123 in c41dab4

expect(el._accessBlocksFind()).to.be.true;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_accessBlockScope'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 127 in c41dab4

el._accessBlockScope = 'paths';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_accessBlocksFind'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 128 in c41dab4

expect(el._accessBlocksFind()).to.be.true;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_accessBlockScope'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 132 in c41dab4

el._accessBlockScope = 'operation';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_accessBlocksFind'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 133 in c41dab4

expect(el._accessBlocksFind()).to.be.true;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_floodgateConfig'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 139 in c41dab4

el._floodgateConfig = new FC('org', 'repo', 'token');

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_configLoading'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 140 in c41dab4

el._configLoading = false;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_accessBlockScope'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 141 in c41dab4

el._accessBlockScope = 'none';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_accessBlocksFind'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 142 in c41dab4

expect(el._accessBlocksFind()).to.be.false;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_selectedOption'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 152 in c41dab4

el._selectedOption = 'fgCopy';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_selectedOption'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 158 in c41dab4

el._selectedOption = 'fgCopy';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_previewAfterCopy'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 159 in c41dab4

el._previewAfterCopy = true;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_selectedOption'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 165 in c41dab4

el._selectedOption = 'fgPromote';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_selectedOption'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 171 in c41dab4

el._selectedOption = 'fgPromote';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_publishAfterPromote'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 172 in c41dab4

el._publishAfterPromote = true;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_selectedOption'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 178 in c41dab4

el._selectedOption = 'fgDelete';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_filesToProcess'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 190 in c41dab4

el._filesToProcess = ['/a', '/b', '/c'];

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_filesToProcess'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 192 in c41dab4

expect(el._filesToProcess).to.deep.equal(['/a', '/c']);

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_cancelled'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 203 in c41dab4

expect(el._cancelled).to.be.true;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_showDialog'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 214 in c41dab4

expect(el._showDialog).to.be.true;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_dialogType'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 215 in c41dab4

expect(el._dialogType).to.equal('delete');

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_dialogMessage'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 216 in c41dab4

expect(el._dialogMessage).to.equal('Are you sure?');

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_showDialog'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 222 in c41dab4

expect(el._showDialog).to.be.false;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_dialogType'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 223 in c41dab4

expect(el._dialogType).to.equal('');

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_org'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 230 in c41dab4

el._org = 'myorg';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_sourceRepo'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 231 in c41dab4

el._sourceRepo = 'myrepo';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_selectedColor'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 232 in c41dab4

el._selectedColor = 'pink';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_filesToProcess'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 236 in c41dab4

el._filesToProcess = ['/myorg/myrepo/page'];

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_filesToProcess'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 244 in c41dab4

el._filesToProcess = ['/myorg/myrepo/data.json'];

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_org'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 255 in c41dab4

el._org = 'myorg';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_sourceRepo'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 256 in c41dab4

el._sourceRepo = 'myrepo';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_selectedColor'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 257 in c41dab4

el._selectedColor = 'blue';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_filesToProcess'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 261 in c41dab4

el._filesToProcess = ['/myorg/myrepo/page', '/myorg/myrepo/file.json'];

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_floodgateConfig'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 276 in c41dab4

el._floodgateConfig = {

🚫 [eslint] <object-curly-newline> _{reported by reviewdog 🐶}
Unexpected line break after this opening brace.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 276 in c41dab4

el._floodgateConfig = {

🚫 [eslint] <object-curly-newline> _{reported by reviewdog 🐶}
Unexpected line break before this closing brace.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 278 in c41dab4

};

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_promoteIgnorePaths'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 280 in c41dab4

    
           expect(el._promoteIgnorePaths).to.deep.equal(['/placeholders.json', '/metadata.json']);

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_floodgateConfig'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 284 in c41dab4

el._floodgateConfig = {

🚫 [eslint] <object-curly-newline> _{reported by reviewdog 🐶}
Unexpected line break after this opening brace.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 284 in c41dab4

el._floodgateConfig = {

🚫 [eslint] <object-curly-newline> _{reported by reviewdog 🐶}
Unexpected line break before this closing brace.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 286 in c41dab4

};

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_promoteIgnorePaths'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 288 in c41dab4

expect(el._promoteIgnorePaths).to.deep.equal(['/my-page.html']);

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_floodgateConfig'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 292 in c41dab4

el._floodgateConfig = {};

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_promoteIgnorePaths'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 294 in c41dab4

expect(el._promoteIgnorePaths).to.deep.equal([]);

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_filesToProcess'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 304 in c41dab4

    
           el._filesToProcess = ['/org/repo/page.html', '/org/repo/placeholders.json', '/org/repo/other.html'];

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_promoteIgnorePaths'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 305 in c41dab4

el._promoteIgnorePaths = ['/placeholders.json'];

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_filesToProcess'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 307 in c41dab4

    
           expect(el._filesToProcess).to.deep.equal(['/org/repo/page.html', '/org/repo/other.html']);

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_promoteIgnoreList'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 308 in c41dab4

expect(el._promoteIgnoreList).to.deep.equal([

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_filesToProcess'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 314 in c41dab4

el._filesToProcess = ['/org/repo/summit25/page.html', '/org/repo/other.html'];

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_promoteIgnorePaths'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 315 in c41dab4

el._promoteIgnorePaths = ['/summit25/'];

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_filesToProcess'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 317 in c41dab4

expect(el._filesToProcess).to.deep.equal(['/org/repo/other.html']);

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_selectedOption'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 359 in c41dab4

el._selectedOption = 'fgCopy';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_copiedFilesCount'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 360 in c41dab4

el._copiedFilesCount = 5;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_copiedErrorList'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 361 in c41dab4

el._copiedErrorList = [{ href: '/a', status: 500 }];

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_copyDuration'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 362 in c41dab4

el._copyDuration = 10;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_selectedOption'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 372 in c41dab4

el._selectedOption = 'fgCopy';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_previewAfterCopy'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 373 in c41dab4

el._previewAfterCopy = true;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_previewDuration'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 374 in c41dab4

el._previewDuration = 5;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_copiedFilesCount'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 375 in c41dab4

el._copiedFilesCount = 3;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_copyDuration'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 376 in c41dab4

el._copyDuration = 2;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_previewedFilesCount'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 377 in c41dab4

el._previewedFilesCount = 3;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_selectedOption'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 384 in c41dab4

el._selectedOption = 'fgPromote';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_promotedFilesCount'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 385 in c41dab4

el._promotedFilesCount = 4;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_promoteDuration'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 386 in c41dab4

el._promoteDuration = 3;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_previewedFilesCount'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 387 in c41dab4

el._previewedFilesCount = 4;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_previewDuration'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 388 in c41dab4

el._previewDuration = 2;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_selectedOption'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 394 in c41dab4

el._selectedOption = 'fgDelete';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_unpublishFilesCount'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 395 in c41dab4

el._unpublishFilesCount = 2;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_unpublishDuration'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 396 in c41dab4

el._unpublishDuration = 1;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_deletedFilesCount'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 397 in c41dab4

el._deletedFilesCount = 2;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_deleteDuration'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 398 in c41dab4

el._deleteDuration = 1;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_org'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 410 in c41dab4

el._org = 'myorg';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_sourceRepo'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 411 in c41dab4

el._sourceRepo = 'myrepo';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_selectedColor'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 412 in c41dab4

el._selectedColor = 'pink';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_floodgateConfig'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 413 in c41dab4

el._floodgateConfig = { some: 'config' };

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_copiedFilesCount'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 414 in c41dab4

el._copiedFilesCount = 5;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_startCopy'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 415 in c41dab4

el._startCopy = true;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_done'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 416 in c41dab4

el._done = true;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_resetWorkflowState'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 418 in c41dab4

el._resetWorkflowState();

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_copiedFilesCount'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 421 in c41dab4

expect(el._copiedFilesCount).to.equal(0);

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_startCopy'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 422 in c41dab4

expect(el._startCopy).to.be.false;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_done'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 423 in c41dab4

expect(el._done).to.be.false;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_filesToProcess'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 424 in c41dab4

expect(el._filesToProcess).to.deep.equal([]);

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_org'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 427 in c41dab4

expect(el._org).to.equal('myorg');

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_sourceRepo'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 428 in c41dab4

expect(el._sourceRepo).to.equal('myrepo');

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_selectedColor'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 429 in c41dab4

expect(el._selectedColor).to.equal('pink');

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_org'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 440 in c41dab4

el._org = 'myorg';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_sourceRepo'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 441 in c41dab4

el._sourceRepo = 'myrepo';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_selectedColor'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 442 in c41dab4

el._selectedColor = 'pink';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_configContextKey'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 443 in c41dab4

el._configContextKey = 'myorg|myrepo';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_org'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 447 in c41dab4

expect(el._org).to.equal('');

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_sourceRepo'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 448 in c41dab4

expect(el._sourceRepo).to.equal('');

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_selectedColor'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 449 in c41dab4

expect(el._selectedColor).to.equal('');

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_configContextKey'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 450 in c41dab4

expect(el._configContextKey).to.equal('');

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_previewAfterCopy'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 462 in c41dab4

expect(el._previewAfterCopy).to.be.true;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_previewAfterCopy'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 464 in c41dab4

expect(el._previewAfterCopy).to.be.false;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_publishAfterPromote'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 469 in c41dab4

expect(el._publishAfterPromote).to.be.true;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_promoteIgnore'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 474 in c41dab4

expect(el._promoteIgnore).to.be.true;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_selectedColor'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 481 in c41dab4

el._selectedColor = 'pink';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_selectedOption'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 485 in c41dab4

el._selectedOption = 'fgCopy';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_selectedOption'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 490 in c41dab4

el._selectedOption = 'fgPromote';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_selectedOption'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 495 in c41dab4

el._selectedOption = 'fgDelete';

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_org'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 526 in c41dab4

expect(el._org).to.equal('myorg');

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_sourceRepo'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 527 in c41dab4

expect(el._sourceRepo).to.equal('myrepo');

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_pathCount'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 528 in c41dab4

expect(el._pathCount).to.equal(2);

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_canStart'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 529 in c41dab4

expect(el._canStart).to.be.true;

🚫 [eslint] <no-underscore-dangle> _{reported by reviewdog 🐶}
Unexpected dangling '_' in '_canStart'.

milo/test/tools/floodbox/floodgate/floodgate.test.js

Line 536 in c41dab4

expect(el._canStart).to.be.false;

🚫 [eslint] <import/no-unresolved> _{reported by reviewdog 🐶}
Unable to resolve path to module 'https://da.live/deps/lit/dist/index.js'.

milo/tools/floodbox/floodgate/floodgate-render.js

Line 2 in c41dab4

import { html, nothing } from 'https://da.live/deps/lit/dist/index.js';

🚫 [eslint] <no-use-before-define> _{reported by reviewdog 🐶}
'validatePathsExist' was used before it was defined.

milo/tools/floodbox/floodgate/floodgate-workflows.js

Line 43 in c41dab4

    
           cmp._notFoundPaths = await validatePathsExist(cmp, regularPaths, org, repo, operation);

🚫 [eslint] <no-use-before-define> _{reported by reviewdog 🐶}
'findFragments' was used before it was defined.

milo/tools/floodbox/floodgate/floodgate-workflows.js

Line 51 in c41dab4

await findFragments(cmp, org, repo, operation);

🚫 [eslint] <max-len> _{reported by reviewdog 🐶}
This line has a length of 106. Maximum allowed is 100.

milo/tools/floodbox/floodgate/floodgate-workflows.js

Line 228 in c41dab4

    
           cmp._previewErrorList.push({ href: status.aemUrl, status: status.statusCode, path: status.path });

🚫 [eslint] <max-len> _{reported by reviewdog 🐶}
This line has a length of 106. Maximum allowed is 100.

milo/tools/floodbox/floodgate/floodgate-workflows.js

Line 252 in c41dab4

    
           cmp._publishErrorList.push({ href: status.aemUrl, status: status.statusCode, path: status.path });

github-actions · 2026-04-11T02:39:26Z

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

github-actions · 2026-04-14T02:55:48Z

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

feat: Floodgate DA Updates and Fixes

c41dab4

github-actions bot reviewed Apr 2, 2026

View reviewed changes

Fix test and lint issues

9e717c3

sukamat approved these changes Apr 6, 2026

View reviewed changes

sabyamon approved these changes Apr 10, 2026

View reviewed changes

Add help icon and link to documentation

fb6c832

aem-code-sync bot deployed to da-floodgate April 13, 2026 17:05 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Floodgate DA Updates and Fixes#5763

feat: Floodgate DA Updates and Fixes#5763
chrischrischris wants to merge 3 commits intostagefrom
da-floodgate

chrischrischris commented Apr 2, 2026 •

edited by github-actions bot

Loading

Uh oh!

aem-code-sync bot commented Apr 2, 2026 •

edited

Loading

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot commented Apr 11, 2026

Uh oh!

github-actions bot commented Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

chrischrischris commented Apr 2, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aem-code-sync bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 11, 2026

Uh oh!

github-actions bot commented Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chrischrischris commented Apr 2, 2026 •

edited by github-actions bot

Loading

aem-code-sync bot commented Apr 2, 2026 •

edited

Loading