Skip to content

MWPW-190760: OST dual-OSI discount support#5700

Open
Axelcureno wants to merge 1 commit intomainfrom
MWPW-190760
Open

MWPW-190760: OST dual-OSI discount support#5700
Axelcureno wants to merge 1 commit intomainfrom
MWPW-190760

Conversation

@Axelcureno
Copy link
Copy Markdown
Member

@Axelcureno Axelcureno commented Mar 26, 2026 •
edited by github-actions bot
Loading

Resolves https://jira.corp.adobe.com/browse/MWPW-190760

Split the comma-separated osi URL parameter into searchOfferSelectorId and initialReferenceOsi so the OST correctly populates the discount reference OSI field when re-opening a dual-OSI discount.

Changes

  • libs/blocks/ost/ost.js: Parse osi param by comma, pass initialReferenceOsi to OST config

Test URLs

Checklist

  • Code follows project conventions
  • Backward compatible (single OSI still works)
  • Tested with dual-OSI discount param

@Axelcureno
MWPW-190760: split dual-OSI param for discount support in OST
2b2d400 
Split comma-separated osi URL parameter into searchOfferSelectorId
and initialReferenceOsi so the OST correctly populates the discount
reference field when re-opening a dual-OSI discount.
@Axelcureno Axelcureno requested a review from a team as a code owner March 26, 2026 17:49
@aem-code-sync
Copy link
Copy Markdown
Contributor

aem-code-sync bot commented Mar 26, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

SNOW Change Request Transaction ID: 0000019c1eec85a3-77ee452

@Axelcureno Axelcureno mentioned this pull request Mar 26, 2026
Merged
5 tasks
@Axelcureno Axelcureno self-assigned this Apr 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Apr 10, 2026
@Axelcureno Axelcureno removed the Stale label Apr 13, 2026
@antonio-rmrz antonio-rmrz mentioned this pull request Apr 15, 2026
Closed
5 tasks
Roycethan
Roycethan requested changes Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Roycethan Roycethan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Axelcureno
On Milo the opening the link from Doc is taking me to below screen and not the discount referenced screen:
try by opening the Discount link: https://da.live/edit#/adobecom/da-cc/drafts/reuben/document

Image

@Axelcureno Axelcureno requested a review from Roycethan April 16, 2026 03:03
@Axelcureno
Copy link
Copy Markdown
Member Author

Axelcureno commented Apr 16, 2026

Both are fixed @Roycethan.

For Milo, use this:
https://mwpw-190760--milo--adobecom.aem.live/tools/ost?token=your-ims-token&osi=Mutn1LYoGojkrcMdCLO7LQlx1FyTHw27ETsfLv0h8DQ%2Cr_JXAnlFI7xD6FxWKl2ODvZriLYBoSL701Kd1hRyhe8&type=discount&old=true

@Roycethan
Copy link
Copy Markdown
Contributor

Roycethan commented Apr 16, 2026

Yes its fixed

@Roycethan Roycethan added verified PR has been E2E tested by a reviewer Ready for Stage labels Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yesil yesil yesil approved these changes

@JasonHowellSlavin JasonHowellSlavin JasonHowellSlavin approved these changes

@mirafedas mirafedas mirafedas approved these changes

@antonio-rmrz antonio-rmrz antonio-rmrz approved these changes

@Roycethan Roycethan Roycethan approved these changes

@joaquinrivero joaquinrivero Awaiting requested review from joaquinrivero

@npeltier npeltier Awaiting requested review from npeltier

@afmicka afmicka Awaiting requested review from afmicka

Assignees

@Axelcureno Axelcureno

Labels

Ready for Stage verified PR has been E2E tested by a reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Axelcureno @Roycethan @yesil @JasonHowellSlavin @mirafedas @antonio-rmrz