Skip to content

MWPW-192308-test: Add ability to create a grouped variation of a collections#818

Open
Andrei4226 wants to merge 1 commit intomainfrom
MWPW-192308-test
Open

MWPW-192308-test: Add ability to create a grouped variation of a collections#818
Andrei4226 wants to merge 1 commit intomainfrom
MWPW-192308-test

Conversation

@Andrei4226
Copy link
Copy Markdown
Contributor

Resolves https://jira.corp.adobe.com/browse/MWPW-192308
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

Please do the steps below before submitting your PR for a code review or QA

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (double check with #fishbags if nala test is needed)
  • C3. Verify all Checks are green (unit tests, nala tests)
  • C4. PR description contains working Test Page link where the feature can be tested
  • C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
  • C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

🧪 Nala E2E Tests

Nala tests run automatically when you open this PR.

To run Nala tests again:

  1. Add the run nala label to this PR (in the right sidebar)
  2. Tests will run automatically on the current commit
  3. Any future commits will also trigger tests as long as the label remains

To stop automatic Nala tests:

  • Remove the run nala label

Note: Tests only run on commits if the run nala label is present. Add the label whenever you need tests to run on new changes.

Test URLs:

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented May 1, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

❌ Patch coverage is 55.17241% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.48%. Comparing base (5d49c47) to head (d9feed9).

Files with missing lines Patch % Lines
studio/src/mas-repository.js 47.05% 9 Missing ⚠️
studio/src/mas-variation-dialog.js 66.66% 4 Missing ⚠️

❌ Your patch check has failed because the patch coverage (55.17%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #818      +/-   ##
==========================================
+ Coverage   87.45%   87.48%   +0.02%     
==========================================
  Files         214      214              
  Lines       63827    63855      +28     
==========================================
+ Hits        55821    55861      +40     
+ Misses       8006     7994      -12     
Files with missing lines Coverage Δ
studio/src/mas-variation-dialog.js 93.54% <66.66%> (-1.00%) ⬇️
studio/src/mas-repository.js 66.23% <47.05%> (-0.14%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d49c47...d9feed9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant