MWPW-193465 Divider Color Select#817
Conversation
|
Can you please resolve conflicts? Thx |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #817 +/- ##
==========================================
- Coverage 87.45% 87.35% -0.11%
==========================================
Files 214 213 -1
Lines 63827 63114 -713
==========================================
- Hits 55821 55133 -688
+ Misses 8006 7981 -25
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| 'spectrum-gray-300-plans', | ||
| 'spectrum-green-900-plans', | ||
| 'spectrum-red-700-plans', | ||
| ], |
There was a problem hiding this comment.
Since this is not plans card we should not use something with name "plans" for the variant that is not plans. It was my mistake to create color names like this and now they are used in the content and we cannot change it. My bad. :( But for other card variants we can use different color names. You already have these in global.css.js that I created for other card variants, so please use these color names
--color-yellow-300-variation: var(--spectrum-yellow-300-plans);
--color-green-900-variation: var(--spectrum-green-900-plans);
--color-gray-300-variation: var(--spectrum-gray-300-plans);
--color-gray-700-variation: var(--spectrum-gray-700-plans);
--color-red-700-variation: var(--spectrum-red-700-plans);
Resolves https://jira.corp.adobe.com/browse/MWPW-193465

Adds option to select divider color for the Mini Compare Chart merch card template.
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Please do the steps below before submitting your PR for a code review or QA
🧪 Nala E2E Tests
Nala tests run automatically when you open this PR.
To run Nala tests again:
run nalalabel to this PR (in the right sidebar)To stop automatic Nala tests:
run nalalabelTest URLs: