Skip to content

MWPW-193465 Divider Color Select#817

Open
Blainegunn wants to merge 4 commits intomainfrom
MWPW-193465
Open

MWPW-193465 Divider Color Select#817
Blainegunn wants to merge 4 commits intomainfrom
MWPW-193465

Conversation

@Blainegunn
Copy link
Copy Markdown
Contributor

@Blainegunn Blainegunn commented Apr 30, 2026

Resolves https://jira.corp.adobe.com/browse/MWPW-193465
Adds option to select divider color for the Mini Compare Chart merch card template.
image

QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

Please do the steps below before submitting your PR for a code review or QA

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (double check with #fishbags if nala test is needed)
  • C3. Verify all Checks are green (unit tests, nala tests)
  • C4. PR description contains working Test Page link where the feature can be tested
  • C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
  • C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

🧪 Nala E2E Tests

Nala tests run automatically when you open this PR.

To run Nala tests again:

  1. Add the run nala label to this PR (in the right sidebar)
  2. Tests will run automatically on the current commit
  3. Any future commits will also trigger tests as long as the label remains

To stop automatic Nala tests:

  • Remove the run nala label

Note: Tests only run on commits if the run nala label is present. Add the label whenever you need tests to run on new changes.

Test URLs:

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Apr 30, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@Blainegunn Blainegunn requested review from a team April 30, 2026 14:22
@honstar
Copy link
Copy Markdown
Contributor

honstar commented Apr 30, 2026

Can you please resolve conflicts? Thx

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

❌ Patch coverage is 85.90909% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.35%. Comparing base (5d49c47) to head (233ec2b).

Files with missing lines Patch % Lines
web-components/src/merch-card.js 26.08% 17 Missing ⚠️
web-components/src/hydrate.js 60.00% 10 Missing ⚠️
studio/src/editors/merch-card-editor.js 84.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #817      +/-   ##
==========================================
- Coverage   87.45%   87.35%   -0.11%     
==========================================
  Files         214      213       -1     
  Lines       63827    63114     -713     
==========================================
- Hits        55821    55133     -688     
+ Misses       8006     7981      -25     
Files with missing lines Coverage Δ
web-components/src/variants/image.js 100.00% <100.00%> (ø)
...components/src/variants/mini-compare-chart-mweb.js 97.42% <100.00%> (+6.08%) ⬆️
...-components/src/variants/mini-compare-chart.css.js 100.00% <100.00%> (ø)
web-components/src/variants/mini-compare-chart.js 77.04% <100.00%> (-1.35%) ⬇️
studio/src/editors/merch-card-editor.js 85.17% <84.00%> (+0.03%) ⬆️
web-components/src/hydrate.js 90.18% <60.00%> (-0.94%) ⬇️
web-components/src/merch-card.js 87.47% <26.08%> (-1.20%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d49c47...233ec2b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

'spectrum-gray-300-plans',
'spectrum-green-900-plans',
'spectrum-red-700-plans',
],
Copy link
Copy Markdown
Contributor

@bozojovicic bozojovicic Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is not plans card we should not use something with name "plans" for the variant that is not plans. It was my mistake to create color names like this and now they are used in the content and we cannot change it. My bad. :( But for other card variants we can use different color names. You already have these in global.css.js that I created for other card variants, so please use these color names

    --color-yellow-300-variation: var(--spectrum-yellow-300-plans);
    --color-green-900-variation: var(--spectrum-green-900-plans);
    --color-gray-300-variation: var(--spectrum-gray-300-plans);
    --color-gray-700-variation: var(--spectrum-gray-700-plans);
    --color-red-700-variation: var(--spectrum-red-700-plans);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants