MWPW-190597: Enabling locale switch for grouped variations#806
Open
MWPW-190597: Enabling locale switch for grouped variations#806
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #806 +/- ##
==========================================
- Coverage 87.45% 87.44% -0.02%
==========================================
Files 214 214
Lines 63827 63871 +44
==========================================
+ Hits 55821 55851 +30
- Misses 8006 8020 +14
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables locale switch in the top nav when editing a grouped variation.
In the locale switch dropdown adds "Not translated" label for all locales for which the language copy of this variation does not exist. When navigating to such a locale, the user gets a choice to either view the en_US copy of this variation or create a translation project (works analogously to the default fragment edition).
As for Nala tests, there is an issue with translating in Nala surface - translation project I created fails: https://mwpw-190597--mas--adobecom.aem.live/studio.html#page=translation-editor&path=nala&translationProjectId=769913f5-bde5-4964-a692-8818df465dd0 (I tried two times). To not block this PR I propose to merge it as is and add Nala tests when the Nala issue is resolved.
Resolves https://jira.corp.adobe.com/browse/MWPW-190597
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Please do the steps below before submitting your PR for a code review or QA
Test URLs:
Before: https://main--mas--adobecom.aem.live/studio.html#expires_in=86399998&fragmentId=3ceec2f2-a508-42a0-bfe6-14f080b9c94e&locale=pl_PL&page=fragment-editor&path=sandbox&token_type=bearer
After:
Merch card grouped variation translated to pl_PL:
https://mwpw-190597--mas--adobecom.aem.live/studio.html#expires_in=86399998&fragmentId=3ceec2f2-a508-42a0-bfe6-14f080b9c94e&locale=pl_PL&page=fragment-editor&path=sandbox&token_type=bearer
Merch card collection grouped variation translated to pl_PL:
https://mwpw-190597--mas--adobecom.aem.live/studio.html#expires_in=86399998&fragmentId=23bee26c-85fb-402e-aa81-70f841744a99&page=fragment-editor&path=sandbox&tags=mas%3Astudio%2Fcontent-type%2Fmerch-card-collection&token_type=bearer