MWPW-193425 Hide VAT labels from strikethrough pricing on M@S cards#801
Open
bozojovicic wants to merge 2 commits intomainfrom
Open
MWPW-193425 Hide VAT labels from strikethrough pricing on M@S cards#801bozojovicic wants to merge 2 commits intomainfrom
bozojovicic wants to merge 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #801 +/- ##
==========================================
+ Coverage 87.41% 87.46% +0.05%
==========================================
Files 210 210
Lines 63081 63131 +50
==========================================
+ Hits 55142 55219 +77
+ Misses 7939 7912 -27
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://jira.corp.adobe.com/browse/MWPW-193425
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Hide all labels in ST price in MAS cards when ST price is used in the main card price in front of the promo price or as part of the promo price (displayed as old price).
These card variants are affected :
catalog, image, product, segment, plans, plans-v2, plans-students, plans-education, special-offers, mini-compare-chart, mini-compare-chart-mweb and mini.We already did it before for :
full-pricing-express and simplified-pricing-express- #712For ccd-suggested, AH variants and fries nothing is changed.
Image
https://mwpw-193425--mas--adobecom.aem.live/studio.html#fragmentId=4e4ce619-c424-4d1b-917e-f1be4d6977c7&page=fragment-editor&path=sandbox
Product
https://mwpw-193425--mas--adobecom.aem.live/studio.html#fragmentId=e942f7d4-153e-4e0d-aedb-87c41874945d&page=fragment-editor&path=sandbox
Plans
https://mwpw-193425--mas--adobecom.aem.live/studio.html#fragmentId=f168a544-3e1f-45bf-b0f5-b5a7c6477229&page=fragment-editor&path=sandbox
Special offers
https://mwpw-193425--mas--adobecom.aem.live/studio.html#fragmentId=a4568e48-4a45-4ad4-b118-b2676bf048f3&page=fragment-editor&path=sandbox
Mini compare chart
https://mwpw-193425--mas--adobecom.aem.live/studio.html#fragmentId=cdfc6905-a68d-4a70-a826-7bc3731022fc&page=fragment-editor&path=sandbox
Mini
https://mwpw-193425--mas--adobecom.aem.live/studio.html#fragmentId=65127775-8cdf-4cfd-a724-15f21a110bd1&page=fragment-editor&path=sandbox
On Milo page
https://main--milo--adobecom.aem.page/drafts/bozo/pr/hide-vat-labels?maslibs=MWPW-193425
Please do the steps below before submitting your PR for a code review or QA
🧪 Nala E2E Tests
Nala tests run automatically when you open this PR.
To run Nala tests again:
run nalalabel to this PR (in the right sidebar)To stop automatic Nala tests:
run nalalabelTest URLs: