Skip to content

MWPW-193425 Hide VAT labels from strikethrough pricing on M@S cards#801

Open
bozojovicic wants to merge 2 commits intomainfrom
MWPW-193425
Open

MWPW-193425 Hide VAT labels from strikethrough pricing on M@S cards#801
bozojovicic wants to merge 2 commits intomainfrom
MWPW-193425

Conversation

@bozojovicic
Copy link
Copy Markdown
Contributor

@bozojovicic bozojovicic commented Apr 29, 2026

Resolves https://jira.corp.adobe.com/browse/MWPW-193425
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

Hide all labels in ST price in MAS cards when ST price is used in the main card price in front of the promo price or as part of the promo price (displayed as old price).

These card variants are affected : catalog, image, product, segment, plans, plans-v2, plans-students, plans-education, special-offers, mini-compare-chart, mini-compare-chart-mweb and mini.
We already did it before for : full-pricing-express and simplified-pricing-express - #712

For ccd-suggested, AH variants and fries nothing is changed.

Image
https://mwpw-193425--mas--adobecom.aem.live/studio.html#fragmentId=4e4ce619-c424-4d1b-917e-f1be4d6977c7&page=fragment-editor&path=sandbox
Product
https://mwpw-193425--mas--adobecom.aem.live/studio.html#fragmentId=e942f7d4-153e-4e0d-aedb-87c41874945d&page=fragment-editor&path=sandbox
Plans
https://mwpw-193425--mas--adobecom.aem.live/studio.html#fragmentId=f168a544-3e1f-45bf-b0f5-b5a7c6477229&page=fragment-editor&path=sandbox
Special offers
https://mwpw-193425--mas--adobecom.aem.live/studio.html#fragmentId=a4568e48-4a45-4ad4-b118-b2676bf048f3&page=fragment-editor&path=sandbox
Mini compare chart
https://mwpw-193425--mas--adobecom.aem.live/studio.html#fragmentId=cdfc6905-a68d-4a70-a826-7bc3731022fc&page=fragment-editor&path=sandbox
Mini
https://mwpw-193425--mas--adobecom.aem.live/studio.html#fragmentId=65127775-8cdf-4cfd-a724-15f21a110bd1&page=fragment-editor&path=sandbox

On Milo page
https://main--milo--adobecom.aem.page/drafts/bozo/pr/hide-vat-labels?maslibs=MWPW-193425

Please do the steps below before submitting your PR for a code review or QA

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (double check with #fishbags if nala test is needed)
  • C3. Verify all Checks are green (unit tests, nala tests)
  • C4. PR description contains working Test Page link where the feature can be tested
  • C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
  • C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

🧪 Nala E2E Tests

Nala tests run automatically when you open this PR.

To run Nala tests again:

  1. Add the run nala label to this PR (in the right sidebar)
  2. Tests will run automatically on the current commit
  3. Any future commits will also trigger tests as long as the label remains

To stop automatic Nala tests:

  • Remove the run nala label

Note: Tests only run on commits if the run nala label is present. Add the label whenever you need tests to run on new changes.

Test URLs:

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Apr 29, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.46%. Comparing base (9fcc076) to head (a8fbd8c).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #801      +/-   ##
==========================================
+ Coverage   87.41%   87.46%   +0.05%     
==========================================
  Files         210      210              
  Lines       63081    63131      +50     
==========================================
+ Hits        55142    55219      +77     
+ Misses       7939     7912      -27     
Files with missing lines Coverage Δ
web-components/src/global.css.js 100.00% <100.00%> (ø)
web-components/src/variants/mini.css.js 100.00% <100.00%> (ø)
web-components/src/variants/plans.css.js 100.00% <100.00%> (ø)
web-components/src/variants/special-offer.css.js 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fcc076...a8fbd8c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant