ci(mwpw-00000): pin Chrome to 146 in E2E workflows to unblock chromedriver install#447
Open
raissanjay wants to merge 2 commits intomainfrom
Open
ci(mwpw-00000): pin Chrome to 146 in E2E workflows to unblock chromedriver install#447raissanjay wants to merge 2 commits intomainfrom
raissanjay wants to merge 2 commits intomainfrom
Conversation
…install
The dynamic 'npm install chromedriver@$CHROME_VERSION' step started failing
when Chrome on the runner moved to 147. chromedriver@147 requires Node >=20
(its postinstall does require('proxy-agent'), and proxy-agent@8 is ESM-only),
which crashes on this workflow's Node 18 with ERR_REQUIRE_ESM.
Pin Chrome to 146 so it matches the chromedriver@^146.0.5 version already in
package.json, and remove the redundant dynamic install step. npm ci now
installs the matching chromedriver (146.x) cleanly on Node 18.
The same dynamic 'npm install chromedriver@$CHROME_VERSION' step exists in pull-request.yaml (run-e2e-tests and run-bulk-publisher-e2e jobs) and fails for the identical reason: chromedriver@147+ requires Node >=20 via ESM-only proxy-agent@8, which crashes on these jobs' Node 16.13.1 and 18 runners with ERR_REQUIRE_ESM. Apply the same fix as the scheduled workflow: pin Chrome to 146 to match chromedriver@^146.0.5 from package.json, and drop the redundant dynamic install step.
sanrai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
npm install chromedriver@$CHROME_VERSIONstep started failing when Chrome on the runner moved to 147.chromedriver@147requires Node >=20 (its postinstall callsrequire('proxy-agent'), andproxy-agent@8is ESM-only), which crashes on this workflow's Node 18 withERR_REQUIRE_ESM.Fix
146so it matches thechromedriver@^146.0.5already pinned inpackage.json.npm install chromedriver@$CHROME_VERSIONstep.npm cialready installs the matching chromedriver (146.x) cleanly on Node 18.No application code, no
package.json, and no Node version changes — this is a CI-only change scoped to the bulk-publisher E2E workflow.