Skip to content

fix(button-base): make aria label change on update after first update lifecycle #5619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(button-base): make aria label change on update after first update lifecycle #5619

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
840f3e7
fix(button-base): make aria label change on update after first update…
tsavka-adobe Jul 21, 2025
a4824c3
Merge branch 'main' into tsavka/button-base-aria-label-update
nikkimk Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions packages/button/src/ButtonBase.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,13 +225,6 @@ export class ButtonBase extends ObserveSlotText(LikeAnchor(Focusable), '', [
if (!this.hasAttribute('tabindex')) {
this.setAttribute('tabindex', '0');
}
if (changed.has('label')) {
if (this.label) {
this.setAttribute('aria-label', this.label);
} else {
this.removeAttribute('aria-label');
}
}
this.manageAnchor();
this.addEventListener('keydown', this.handleKeydown);
this.addEventListener('keypress', this.handleKeypress);
Expand All @@ -255,6 +248,14 @@ export class ButtonBase extends ObserveSlotText(LikeAnchor(Focusable), '', [
// Set up focus delegation
this.anchorElement.addEventListener('focus', this.proxyFocus);
}

if (changed.has('label')) {
if (this.label) {
this.setAttribute('aria-label', this.label);
} else {
this.removeAttribute('aria-label');
}
}
Comment on lines +252 to +258
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. Its a miss edge case from our side. But for better code maintainability can you extract this logic into a private method to avoid duplication. There are three instances of the same code. Second can you please add a test to verify aria-label changes when the label property changes after initial render.

}
protected override update(changes: PropertyValues): void {
super.update(changes);
Expand Down