fix(combobox): remove layout thrash in render #5538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e5abda5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 84 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tjgupta
commented
Jun 12, 2025
packages/combobox/package.json
Outdated
| "@spectrum-web-components/picker-button": "1.6.0", | ||
| "@spectrum-web-components/popover": "1.6.0", | ||
| "@spectrum-web-components/progress-circle": "1.6.0", | ||
| "@spectrum-web-components/reactive-controllers": "1.6.0", |
Contributor
Author
There was a problem hiding this comment.
This isn't really related to my change, but the precommit hook was failing the linter without this.
Contributor
There was a problem hiding this comment.
Yes the extraneous dependency check found this. This is cool!
tjgupta
force-pushed
the
tjgupta/fix-combobox-perf
branch
from
029dc01 to
2f6ca61
Compare
rubencarvalho
force-pushed
the
tjgupta/fix-combobox-perf
branch
from
f3c9ef8 to
2f6ca61
Compare
Contributor
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🚫 [eslint] <notice/notice> reported by reviewdog 🐶
Missing notice header
Contributor
Tachometer resultsChromecombobox permalinkbasic-test
light-dom-test permalink
Firefoxcombobox permalinkbasic-test
light-dom-test permalink
|
rubencarvalho
force-pushed
the
tjgupta/fix-combobox-perf
branch
from
b4e7408 to
e29da59
Compare
Rajdeepc
reviewed
Jun 13, 2025
Rajdeepc
requested changes
Jun 13, 2025
Rajdeepc
approved these changes
Jun 14, 2025
Contributor
Rajdeepc
left a comment
Rajdeepc
left a comment
There was a problem hiding this comment.
LGTM! Thanks for doing this.
Rajdeepc
changed the title
rubencarvalho
approved these changes
Jun 17, 2025
Contributor
rubencarvalho
left a comment
rubencarvalho
left a comment
There was a problem hiding this comment.
Thank you for this contribution! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change removes a layout thrashing (style invalidation/recalculation) found in the render function of the Combobox component.
Motivation and context
Removes a performance bottleneck.
Related issue(s)
Screenshots (if appropriate)
Before:
After:
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Descriptive Test Statement
Descriptive Test Statement
Device review