-
Notifications
You must be signed in to change notification settings - Fork 225
chore: update and fix release scripts #5528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the best works I've seen in my life!
@@ -31,6 +31,7 @@ | |||
"changeset-publish": "yarn prepublishOnly && yarn changeset version && yarn constraints --fix && yarn install --refresh-lockfile && yarn version:update && yarn changeset publish --no-git-tag && yarn push-to-remote && yarn create-git-tag && yarn postpublish", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected object keys to be in ascending order. 'changeset-publish' should be before 'changeset-snapshot-publish'.
reviewdog suggestion error
GitHub comment range and suggestion line range must be same. L31-L31 v.s. L29-L31@@ -31,6 +31,7 @@ | |||
"changeset-publish": "yarn prepublishOnly && yarn changeset version && yarn constraints --fix && yarn install --refresh-lockfile && yarn version:update && yarn changeset publish --no-git-tag && yarn push-to-remote && yarn create-git-tag && yarn postpublish", | |||
"changelog:global": "node ./scripts/update-global-changelog.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected object keys to be in ascending order. 'changelog:global' should be before 'changeset-publish'.
Description
Updated the release process scripts in package.json:
create-git-tag
was forgotten.changelog:global
script (inprepublishOnly
) to automatically updating the global changelog and avoid PRs like chore: update global changelog #5527publish:react
script to do releases using the--tag latest
Motivation and context
Fixing commands and adding the missing scripts so there is no more manual work involved in a release.
Author's checklist
Reviewer's checklist
patch
,minor
, ormajor
features