Skip to content

chore: update and fix release scripts #5528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2025
Merged

Conversation

rubencarvalho
Copy link
Contributor

@rubencarvalho rubencarvalho commented Jun 11, 2025

Description

Updated the release process scripts in package.json:

  • The create-git-tag was forgotten.
  • Added changelog:global script (in prepublishOnly) to automatically updating the global changelog and avoid PRs like chore: update global changelog #5527
  • Updated the publish:react script to do releases using the --tag latest

Motivation and context

Fixing commands and adding the missing scripts so there is no more manual work involved in a release.

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Copy link

changeset-bot bot commented Jun 11, 2025

⚠️ No Changeset found

Latest commit: 21fd883

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rubencarvalho rubencarvalho marked this pull request as ready for review June 11, 2025 14:25
@rubencarvalho rubencarvalho requested a review from a team as a code owner June 11, 2025 14:25
Copy link

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link

Tachometer results

Currently, no packages are changed by this PR...

Copy link
Contributor

@TarunAdobe TarunAdobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the best works I've seen in my life!

@rubencarvalho rubencarvalho enabled auto-merge (squash) June 12, 2025 10:04
@@ -31,6 +31,7 @@
"changeset-publish": "yarn prepublishOnly && yarn changeset version && yarn constraints --fix && yarn install --refresh-lockfile && yarn version:update && yarn changeset publish --no-git-tag && yarn push-to-remote && yarn create-git-tag && yarn postpublish",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'changeset-publish' should be before 'changeset-snapshot-publish'.

reviewdog suggestion errorGitHub comment range and suggestion line range must be same. L31-L31 v.s. L29-L31

@@ -31,6 +31,7 @@
"changeset-publish": "yarn prepublishOnly && yarn changeset version && yarn constraints --fix && yarn install --refresh-lockfile && yarn version:update && yarn changeset publish --no-git-tag && yarn push-to-remote && yarn create-git-tag && yarn postpublish",
"changelog:global": "node ./scripts/update-global-changelog.js",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'changelog:global' should be before 'changeset-publish'.

reviewdog suggestion errorGitHub comment range and suggestion line range must be same. L32-L32 v.s. L29-L32

@rubencarvalho rubencarvalho disabled auto-merge June 12, 2025 22:38
@rubencarvalho rubencarvalho merged commit 924f2df into main Jun 12, 2025
21 of 23 checks passed
@rubencarvalho rubencarvalho deleted the ruben/fix-release-commands branch June 12, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants