fix(actions): validate action's latest-CLI lookup can miss the tag - #1448
Open
GarthDB wants to merge 6 commits into
Open
fix(actions): validate action's latest-CLI lookup can miss the tag#1448GarthDB wants to merge 6 commits into
GarthDB wants to merge 6 commits into
Conversation
Bead cn3v.2 — mode-group membership primitive for the Figma exporter's future mode-groups work. Generalizes the PR #1437 test-only spike (concept_diverges_on_axis) into a real method that auto-derives "every other declared mode set held at its default" from self.mode_sets, instead of requiring the caller to build that context by hand. - sdk/core/src/graph.rs: adds TokenGraph::diverges_on_axis(legacy_key, mode_set), built only on resolve_relationship_ref_in_context (no new resolver logic); adds diverges_on_axis_reports_mode_group_membership unit test proving a light!=dark color token reports true on colorScheme/false on scale, and a scale-invariant token reports false on colorScheme. No exporter wiring yet — primitive only, per bead AC. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…nding Part of bead vpk.2 (SPEC-027 button.json cleanup). Confirmed via relationships/button.json's "Rounding (with wrapping)" CTR entry ($ref d639a0b5-16b4-4d75-ab37-d87815c7b500 -> layout.tokens.json corner-radius size:xl) that the extra-large slot is already correctly modeled through the CTR relationship. The legacy corner-radius-button- extra-large key doesn't exist anywhere in tokens/ -- pure dangling tokenBindings entry, safe to drop outright. The other two dangling entries (corner-radius-button-small/-large) still need a design-owner call between the corner-radius-small-size-* and corner-radius-medium-size-* legacy families before they can be rebound or removed -- left as-is pending that sign-off. - packages/design-data/components/button.json: removes the corner-radius-button-extra-large tokenBindings entry. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Part of bead vpk.2. Figma's S2 Token-specs "Button" page (node 8476:1743, "Rounding (with wrapping)" section) confirms this is a genuine, distinct 24px slot for the XL button size — not redundant with the existing CTR relationship. That CTR's single $ref (uuid d639a0b5) resolves to a different, confusingly-named 16px value (legacy key corner-radius-extra-large-default, actually the M-size default) — it does not cover S/L/XL sizes at all. This reverts 85ee444, which incorrectly treated the XL binding as stale and removed it. All three dangling bindings (corner-radius-button-{small,large,extra-large}) are equally blocked on a design-owner decision about which token family (small-size vs medium-size) they should resolve to — none should be removed. - packages/design-data/components/button.json: restore the corner-radius-button-extra-large tokenBindings entry. - .changeset/button-corner-radius-extra-large-binding.md: remove — the change it described was incorrect. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
gh release list --limit 50 only returns the 50 most recently published releases across the whole repo. Other packages here release far more often than design-data-cli, so its tag can scroll off that window, resolving `version` to an empty string and producing a 404 when the action tries to download design-data-linux-x64 for tag "design-data-cli@". Bump the limit and fail loudly instead of building a bogus download URL if no matching tag is found. Found via GarthDB/spectrum-ios-design-data#5 CI failure.
|
Contributor
🎨 Token Changes ReportTokens Changed (0)Original Branch: This comment was automatically generated by the token diff tool. 🤖 |
Contributor
🧩 Component Schema Changes ReportNo component schema changes detected.This comment was automatically generated by the component schema diff tool. 🤖 |
Contributor
Run report for ec486c09Total time: 2m 15s | Comparison time: 4m | Estimated savings: 1m 44s (43.5% faster)
Changed files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validatecomposite action's release-resolution step forcli-version: latestonly scans the 50 most recently published releases in this repo (gh release list --limit 50). Other packages (design-data-mcp,design-system-registry, etc.) release far more often thandesign-data-cli, so its tag scrolls off that window andversionsilently resolves to an empty string, producing acurl: (22) 404when the action tries to downloaddesign-data-linux-x64for the bogus tagdesign-data-cli@.--limitto 1000 and fails loudly (::error::+exit 1) instead of building a bogus download URL when no matching tag is found, so this class of bug surfaces immediately instead of as an opaque curl 404.Found while regenerating
GarthDB/spectrum-ios-design-datafor the splitextensions/layout — see PR #5 there, whose CI failed on this exact lookup.Test plan
gh release list --repo adobe/spectrum-design-data --limit 1000 --json tagName --jq '.[].tagName | select(startswith("design-data-cli@"))'findsdesign-data-cli@0.12.1(the most recent CLI release), which the old--limit 50missed.cli-version: "0.12.1"explicitly as a belt-and-suspenders workaround; can revert that pin back tolatestonce this lands.