fix(docs): resolve.mjs crash and duplicate work in s2-tokens-viewer - #1350
Merged
Conversation
🦋 Changeset detectedLatest commit: 84f9334 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🧩 Component Schema Changes ReportNo component schema changes detected.This comment was automatically generated by the component schema diff tool. 🤖 |
Contributor
🎨 Token Changes ReportTokens Changed (0)Original Branch: This comment was automatically generated by the token diff tool. 🤖 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes two issues in
docs/s2-tokens-viewer/scripts/resolve.mjsfound duringreview of #1341:
scripts/resolve.mjs:loadCascadeTokens()now throws a clear error namingmoon run viewer:convertwhencascade/is missing, instead of an uncaughtENOENT.scripts/resolve.mjs: mergedbuildColorComponentFile()andbuildLayoutComponentFile()into a single
buildComponentFiles()pass overtokensDirso each component token file isread, parsed, and checked for color-domain only once instead of twice.
Related Issue
Found during review of #1341.
Motivation and Context
The missing-
cascade/case failed with a rawENOENTstack trace instead of telling thedeveloper how to fix it, and the two build functions duplicated the same file-read/parse/
color-check work for no benefit.
How Has This Been Tested?
moon run s2-tokens-viewer:convertthennode scripts/resolve.mjs— output matchesthe prior known-good aggregate counts (83 color-component tokens, 1267 layout-component
tokens, 4194 cascade tokens, 0 missing in wasm resolution).
cascade/away and reran — got the new clear error instead of an uncaughtENOENT.node tools/changeset-linter/src/cli.js check --fail-on-warningspasses.Screenshots (if appropriate):
N/A
Types of changes
Checklist: