feat(tokens): add opacity + transparency tokens, deprecate legacy transparency tokens - #1348
Open
GarthDB wants to merge 1 commit into
Open
feat(tokens): add opacity + transparency tokens, deprecate legacy transparency tokens#1348GarthDB wants to merge 1 commit into
GarthDB wants to merge 1 commit into
Conversation
…nsparency tokens Adds the opacity-* foundation scale, transparent-static-* and transparent-neutral[-inverse]-* color families, and deprecates the legacy transparent-white-*/transparent-black-*/white/black tokens they replace, for the AI Branding work. Closes #1344, #1345, #1346, #1347. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 4447e20 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Run report for 4447e209Total time: 1m 9s | Comparison time: 1m 52s | Estimated savings: 42.9s (38.2% faster)
Expanded report
Changed files |
Contributor
🎨 Token Changes ReportTokens Changed (118)Original Branch: Newly Deprecated (28)
Added (90)
This comment was automatically generated by the token diff tool. 🤖 |
Contributor
🧩 Component Schema Changes ReportNo component schema changes detected.This comment was automatically generated by the component schema diff tool. 🤖 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the opacity + transparency token changes Miruna requested for the AI Branding work:
opacity-*foundation scale (color-aliases.tokens.json/color-aliases.json).transparent-static-{white,black}-*colors built on that scale (color-palette.tokens.json/color-palette.json).transparent-neutral[-inverse]-*colors, light/dark/wireframe (same files).transparent-white-*,transparent-black-*,white,black), each pointing (renamed) at itstransparent-static-*replacement.colorFamilyvalues (transparent-static-white,transparent-static-black,transparent-neutral,transparent-neutral-inverse) inpackages/design-data/registry/color-families.json, regeneratessdk/core/src/registry_data.rsandpackages/tokens/snapshots/validation-snapshot.jsonaccordingly.Authored by hand-editing the cascade files (
packages/design-data/tokens/*.tokens.json, canonical perpackages/design-data/README.md) and regenerating the legacypackages/tokens/src/mirror viamoon run design-data:legacy-output.Related Issue
Closes #1344, #1345, #1346, #1347.
Motivation and Context
Introduces a reusable opacity scale as the foundation for a consistent, predictable
transparent-color taxonomy, and gives designers mode-aware neutral transparency tokens so
they don't have to manually pick white vs. black per theme. Deprecating the legacy tokens
establishes a clear migration path and reduces duplicated/inconsistent transparent values.
Flagged for review: a handful of the deprecation mappings are intentional value shifts to
align with the new opacity scale (e.g.
transparent-white-600→transparent-static-white-700,transparent-white-800→transparent-static-white-900,transparent-black-700→transparent-static-black-800) — these should get a contrast check before/at migration.Also,
whiteandblackare foundational and widely aliased elsewhere in the corpus; perthe issue, no consumer audit has been done yet — deprecation is non-destructive (they
still resolve via
renamed), but please weigh in before this merges.How Has This Been Tested?
moon run design-data:validate— clean (new colorFamily values registered; no new warnings).moon run design-data:legacy-output+moon run design-data:roundtrip-verify— cascade/legacy in sync.moon run tokens:test— 27/27 passing (schema validation, uuid uniqueness,checkRenamedtarget-existence, package contents).moon run tokens:verifyDesignDataSnapshot— snapshot regenerated and verified.moon run sdk:test— 1290/1290 Rust tests passing.transparent-static-white-0,transparent-neutral-100, deprecatedwhite/transparent-white-600) for correct values andrenamedtargets.Screenshots (if appropriate):
N/A — token data change.
Types of changes
Checklist: