Skip to content

fix: filter DOM props on TabPanels #9432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yihuiliao merged 1 commit into from
Jan 6, 2026
Merged

fix: filter DOM props on TabPanels #9432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/react-aria-components/src/Tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,9 +394,12 @@ export const TabPanels = /*#__PURE__*/ createHideableComponent(function TabPanel
prevSize.current = ref.current.getBoundingClientRect();
}

let DOMProps = filterDOMProps(props, {global: true});
delete DOMProps.id;

return (
<div
{...props}
{...DOMProps}
Comment on lines -399 to +402

@LFDanLu LFDanLu Jan 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resurrecting this since I was out during this time, but I think this change means we will need to add the user provided style prop now unless it was judged that we don't want that for TabsPanels?

@snowystinger snowystinger Jan 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, yes, we'll need to add that since we don't have renderProps
we'll also need to add labelling https://d5iwopk28bdhl.cloudfront.net/pr/b6cf703b99c98b8bf5a7c0bb613e91ccf1b85153/Tabs#tabpanel

ref={ref}
className={props.className || 'react-aria-TabPanels'}>
<Collection {...props} />
Expand Down