Skip to content

docs: docs testing followups #9175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 12, 2025
Merged

docs: docs testing followups #9175

merged 9 commits into from
Nov 12, 2025
+412 −85

Conversation

@LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Nov 12, 2025 •
edited
Loading

  • Add markdown stripping to the search card descriptions
  • fix icons search overflow and focus visible styles
  • add colorEditor for color picker blog example
  • make videos full width in the blog posts
  • add background to first submenu blog post animation
  • got rid of max width on the blog and releases index page since they don't have a ToC and thus don't need to be limited

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

RSP

@rspbot
Copy link

rspbot commented Nov 12, 2025

Build successful! 🎉

snowystinger
snowystinger previously approved these changes Nov 12, 2025
View reviewed changes
reidbarber
reidbarber requested changes Nov 12, 2025
View reviewed changes
packages/dev/s2-docs/pages/react-aria/blog/ColorEditorExample.tsx Outdated
<ColorEditor />
<div style={{display: 'flex', gap: 8, alignItems: 'center', marginTop: 16}}>
<ColorSwatch color={color} size="L" />
<span style={{fontSize: 16, fontWeight: 500}}>{color.getColorName(navigator.language || 'en-US')}</span>
Copy link
Member

@reidbarber reidbarber Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: we could use adobe clean here

@LFDanLu LFDanLu marked this pull request as draft November 12, 2025 20:59
@rspbot
Copy link

rspbot commented Nov 12, 2025

Build successful! 🎉

@LFDanLu LFDanLu marked this pull request as ready for review November 12, 2025 21:15
@rspbot
Copy link

rspbot commented Nov 12, 2025

Build successful! 🎉

reidbarber
reidbarber previously approved these changes Nov 12, 2025
View reviewed changes
snowystinger
snowystinger previously approved these changes Nov 12, 2025
View reviewed changes
@LFDanLu LFDanLu dismissed stale reviews from snowystinger and reidbarber via 460dd6e November 12, 2025 21:59
@LFDanLu LFDanLu enabled auto-merge November 12, 2025 22:02
@rspbot
Copy link

rspbot commented Nov 12, 2025

Build successful! 🎉

@LFDanLu LFDanLu added this pull request to the merge queue Nov 12, 2025
Merged via the queue into main with commit 075f2ed Nov 12, 2025
33 checks passed
@LFDanLu LFDanLu deleted the testing_followups branch November 12, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snowystinger snowystinger snowystinger approved these changes

@reidbarber reidbarber reidbarber approved these changes

Assignees

No one assigned

Labels

release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LFDanLu @rspbot @snowystinger @reidbarber