Skip to content

fix flip behavior for select in dialog #8631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sfc-gh-alisowski
Copy link

@sfc-gh-alisowski sfc-gh-alisowski commented Jul 24, 2025

I was experiencing a bug where:

  • a select with maxHeight set on it rendered in a dialog
  • if the select has lots of options it would always flip, no matter the available space

I traced the code to here where it disregards the userSetMaxHeight when determining if needed to flip

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Snowflake

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The change looks right, but can you provide a reproduction so we can verify the fix? a storybook story is fine
I attempted to see if it fixed #7897 or #7960 to no avail unfortunately.

@sfc-gh-alisowski
Copy link
Author

Will do. I'm about to go on a 2 week vacation but will def look when I'm back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants