Skip to content

fix: add date picker placeholder for Norwegian Bokmål #8594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

16patsle
Copy link

Closes #8593

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Testing a date picker with the locale set to "nb-NO" should produce the same placeholder as "nn-NO", that is "dd.mm.åååå".

🧢 Your Project:

@16patsle
Copy link
Author

It feels a bit silly for a change that's copy-paste and change a single letter, but I guess I can get the CLA sorted out too

@snowystinger
Copy link
Member

If you cannot sign the CLA, let us know so we can open our own PR for it. I agree it's a bit silly for something so small, especially since there is no other way to do it, but alas, I do not make the rules for this :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date picker placeholder missing for Norwegian Bokmål
2 participants