Skip to content

fix: make sure avatars appear if Combobox/Picker is in Dialog - #10482

Queued
LFDanLu wants to merge 2 commits into
mainfrom
combobox_dialog_context_clear
Queued

fix: make sure avatars appear if Combobox/Picker is in Dialog#10482
LFDanLu wants to merge 2 commits into
mainfrom
combobox_dialog_context_clear

Conversation

@LFDanLu

@LFDanLu LFDanLu commented Aug 19, 2026

Copy link
Copy Markdown
Member

From slack

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices
  • I understand every change in this PR and can explain why it's there.
  • If AI-assisted, I followed our AI contribution guidance and pointed my assistant at CLAUDE.md.

📝 Test Instructions:

Run chromatic and check stories

🧢 Your Project:

RSP

Comment thread packages/@react-spectrum/s2/src/ComboBox.tsx Outdated
Comment thread packages/@react-spectrum/s2/src/Picker.tsx Outdated
@rspbot

rspbot commented Aug 19, 2026

Copy link
Copy Markdown

@rspbot

rspbot commented Aug 19, 2026

Copy link
Copy Markdown

Agent Skills Changes

Modified (2)
Install

React Spectrum S2:

npx skills add https://d1pzu54gtk2aed.cloudfront.net/pr/983edd6a4de41304d9d201105937cfff44b619a2/

React Aria:

npx skills add https://d5iwopk28bdhl.cloudfront.net/pr/983edd6a4de41304d9d201105937cfff44b619a2/

@snowystinger snowystinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I think that's better, now people can't inadvertently change Images inside Avatars

@LFDanLu
LFDanLu added this pull request to the merge queue Aug 20, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants