feat: s2 donut binary - #888
Draft
madelineluke wants to merge 1 commit into
Draft
Conversation
…ry segment The isBoolean (2-segment) donut always rendered its secondary arc via the normal categorical color scale instead of the fixed chart.donut.color.secondary-gray token the design requires, so consumers had to manually pass a gray color as a workaround. The secondary segment now always resolves to secondary-gray, matching the same fixed-token precedent already used for the empty-state ring. Revised the donut-binary spec after confirming the skill's "only the primary segment is labeled" note describes the existing center-hole DonutSummary value, not the outside-ring SegmentLabel component - SegmentLabel remains intentionally suppressed for binary donuts. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-888 🎨 S2 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-888-s2 📚 Docs -> https://opensource.adobe.com/react-spectrum-charts/PR-888-docs/ |
madelineluke
marked this pull request as draft
August 19, 2026 19:35
madelineluke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Forces the non-primary segment of a boolean (
isBoolean) donut to always renderchart.donut.color.secondary-gray(#C6C6C6), regardless of the categorical color scale/domain - matching the same fixed-token precedent already used for the empty-state ring. Adds a new non-pre-alphaDonut/FeaturesStorybook location (stories/Donut/Features/DonutBinary.story.tsx) for upcoming s2 donut feature work. Revisesplanning/specs/donut/donut-binary.json: drops the "primary-only SegmentLabel" requirement after confirming the design skill's "only the primary segment is labeled" note refers to the existing center-holeDonutSummaryvalue, not the outside-ringSegmentLabelcomponent (which remains intentionally suppressed for binary donuts).Related Issue
Implements
planning/specs/donut/donut-binary.json- first (smallest/no-dependency) spec in theplanning/specs/donut/s2 donut feature series. No GitHub issue tracked.Motivation and Context
The 2-segment (
isBoolean) donut's secondary segment currently renders via the normal categorical color scale instead of the fixed design token, so consumers had to manually pass a gray color as a workaround.How Has This Been Tested?
yarn test --testPathPattern="vega-spec-builder-s2/src/donut"- 57/57 passingyarn test --testPathPattern="react-spectrum-charts-s2"- 491/491 passingyarn lint- cleanyarn tsc --noEmit- no new errors (pre-existing unrelated errors confirmed present onmain)Donut/Features/Binary) that the secondary segment renders gray regardless of data order/color domainScreenshots (if appropriate):
N/A - verified in Storybook, see test plan above.
Types of changes
Checklist: