fix: avoid using fragment panels#390
Merged
sharanyavinod merged 2 commits intoewfrom Apr 24, 2026
Merged
Conversation
hannessolo
reviewed
Apr 24, 2026
| }); | ||
|
|
||
| // Restore any panels that were open in the previous session. | ||
| // Restore panels opened by canvas (no fragment URL). Fragment-based entries are legacy |
Contributor
There was a problem hiding this comment.
I'm not sure I'd call it legacy - other features that use nx might want to use panels with fragments, as that's a common edge delivery pattern. Here it makes more sense if canvas just controls them.
hannessolo
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous panel stored as fragment and current implementation are creating duplicates -> fix to avoid using previously stored fragments within canvas
Preview: https://da.live/canvas?nx=ew-panels&nxver=2#/exp-workspace/frescopa/index