Skip to content

Exp Workspace - Editor feature parity#385

Merged
hannessolo merged 11 commits intoewfrom
ew-plugins
Apr 24, 2026
Merged

Exp Workspace - Editor feature parity#385
hannessolo merged 11 commits intoewfrom
ew-plugins

Conversation

@hannessolo
Copy link
Copy Markdown
Contributor

@hannessolo hannessolo commented Apr 23, 2026

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Apr 23, 2026 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@sharanyavinod
Copy link
Copy Markdown

sharanyavinod commented Apr 23, 2026

The coloring/sizing of the publish button seems really out of place with the rest of the page now
Screenshot 2026-04-23 at 15 11 52
Screenshot 2026-04-23 at 15 12 15

@hannessolo
Copy link
Copy Markdown
Contributor Author

hannessolo commented Apr 23, 2026 •
edited by sharanyavinod
Loading

Agreed but I don't see any publish button in the UX designs so I just had to do something... better ideas?

Sizing -> update to match the profile button
Color -> I think maybe ok as is for now since it needs more attention, can check with Kilian once he's back

sharanyavinod
sharanyavinod reviewed Apr 23, 2026
View reviewed changes
Comment thread nx2/blocks/canvas/nx-editor-doc/prose.js Outdated
sharanyavinod
sharanyavinod reviewed Apr 23, 2026
View reviewed changes
Comment thread nx2/blocks/canvas-actions/canvas-actions.js Outdated
Comment thread nx2/blocks/canvas-actions/canvas-actions.js
Comment thread nx2/blocks/canvas-actions/canvas-actions.js Outdated
Comment thread nx2/blocks/canvas-actions/canvas-actions.js Outdated
Comment thread nx2/blocks/canvas-actions/canvas-actions.js Outdated
Comment thread nx2/blocks/canvas/canvas.js
const mountRoot = canvasEditorMountRoot(block);
mountRoot.classList.add('nx-canvas-editor-mount');

mountRoot.addEventListener('nx-editor-undo-state', (e) => {
Copy link
Copy Markdown

@sharanyavinod sharanyavinod Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future - maybe we should move all events out to constants and reuse so we have a clear view + avoid regressions

Copy link
Copy Markdown
Contributor Author

@hannessolo hannessolo Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, this would be a good refactoring task.

@hannessolo hannessolo merged commit e3310a2 into ew Apr 24, 2026
3 checks passed
@hannessolo hannessolo deleted the ew-plugins branch April 24, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sharanyavinod sharanyavinod sharanyavinod approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hannessolo @sharanyavinod