Skip to content

fix:migrated from custom state management to Lit's reactive props#318

Closed
kmurugulla wants to merge 1 commit intomainfrom
mlstate
Closed

fix:migrated from custom state management to Lit's reactive props#318
kmurugulla wants to merge 1 commit intomainfrom
mlstate

Conversation

@kmurugulla
Copy link
Copy Markdown
Contributor

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Apr 5, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@kmurugulla kmurugulla requested a review from amol-anand April 5, 2026 16:41
@kmurugulla kmurugulla marked this pull request as draft April 5, 2026 16:41
@kmurugulla
Copy link
Copy Markdown
Contributor Author

Used Slicc for analysis with the following prompt when i have Media Library opened with main and state migrate branch

`I have two Media Library Tabs .

First one is with a branch where the code is depending on Lit State
Second with a custom state management
#318 has the changes i made
While this reduces number of lines of code , I want to confirm whether this is the worth clean up

-Without causing any regression
-how many lines of code are we saving
-Is depending on Lit state a better dev or design principle
-Are the operations like Search , Index , Incremental index ( you have to refresh the page to kick in incremtal index) is any faster
-Is opening the modal , or navigation is any faster
-We have the state being pushed into url to create deep links . Are those operations any faster .

Please test and give me report as a table to make the decision .`

And the report shows that custom state is much better

image

So closing this PR.

@kmurugulla kmurugulla closed this Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant