Skip to content

feat(media-library): add preview.da.live authentication support for p…#308

Merged
kmurugulla merged 2 commits intomainfrom
imgpreview
Apr 2, 2026
Merged

feat(media-library): add preview.da.live authentication support for p…#308
kmurugulla merged 2 commits intomainfrom
imgpreview

Conversation

@kmurugulla
Copy link
Copy Markdown
Contributor

…rotected sites

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

Changes

  • Auto-detects auth requirements via HEAD request to index.md
  • Sets partitioned cookie on preview.da.live for authenticated access
  • Displays images using preview.da.live URLs & while fetching metadata through CORS proxy with site tokens
  • Maintains auth context during modal navigation
  • Improves error messages (removes HTTP status codes)

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Apr 2, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@kmurugulla kmurugulla requested a review from amol-anand April 2, 2026 16:15
Copy link
Copy Markdown
Contributor

@amol-anand amol-anand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review — 5 issues flagged (2 high priority, 3 medium priority). See inline comments.

Comment thread nx/blocks/media-library/core/utils.js
Comment thread nx/blocks/media-library/views/mediainfo/mediainfo.js Outdated
Comment thread nx/blocks/media-library/core/urls.js
Comment thread nx/blocks/media-library/media-library.js
Comment thread nx/blocks/media-library/core/utils.js Outdated
@kmurugulla kmurugulla merged commit 8f60edf into main Apr 2, 2026
2 checks passed
@kmurugulla kmurugulla deleted the imgpreview branch April 2, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants