Re-enable dependency based JRE #2434
Open
+21
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like this was finally fixed in a JRE 21 patch version
There was a problem hiding this comment.
Pull Request Overview
This PR restores dynamic JRE creation by unpacking the Spring Boot fat JAR, discovering required modules with jdeps (targeting Java 21), and building a minimal runtime with jlink.
- Unpacked
s3mock-exec.jarfor dependency analysis - Reactivated
jdepswith--multi-release 21and output tojre-deps.info - Invoked
jlinkusing discovered modules plusjdk.crypto.ec
Comments suppressed due to low confidence (1)
docker/Dockerfile:47
jlinkrequires a--module-pathpointing to the JDK modules (e.g.,--module-path "$JAVA_HOME/jmods") so it can locate platform modules when assembling the minimal JRE.
RUN jlink \
| --print-module-deps \ | ||
| --recursive \ | ||
| # specify the the dependencies for the jar | ||
| --class-path ${TMP_DIR}/BOOT-INF/lib/* ${TMP_DIR}/BOOT-INF/classes ${TMP_DIR} \ |
There was a problem hiding this comment.
The --class-path flag expects a single classpath string; combine multiple paths with ':' (e.g., --class-path ${TMP_DIR}/BOOT-INF/lib/*:${TMP_DIR}/BOOT-INF/classes:${TMP_DIR}) rather than passing separate arguments.
Suggested change
| --class-path ${TMP_DIR}/BOOT-INF/lib/* ${TMP_DIR}/BOOT-INF/classes ${TMP_DIR} \ | |
| --class-path ${TMP_DIR}/BOOT-INF/lib/*:${TMP_DIR}/BOOT-INF/classes:${TMP_DIR} \ |
Copilot uses AI. Check for mistakes.
| # --output "$JAVA_MINIMAL" | ||
| # find JDK dependencies dynamically from unpacked jar | ||
| RUN jdeps \ | ||
| # dont worry about missing modules |
There was a problem hiding this comment.
[nitpick] Consider using the correct contraction don't instead of dont for clarity in comments.
Suggested change
| # dont worry about missing modules | |
| # don't worry about missing modules |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like this was finally fixed in a JRE 21 patch version
Related Issue
N/A
Tasks