Skip to content

Update popup.js with 404 behavior and apostrophe for displaying usernames #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spassarop wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update popup.js with 404 behavior and apostrophe for displaying usernames #90

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8e8647
Change behavior when getting 404
spassarop Oct 21, 2018
1a32b8c
Add `'` to username display and conditional display of 's'
spassarop Oct 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions popup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,10 @@ function getXHR(url) {
document.getElementById("check").style.visibility = "collapse";
document.getElementById("show").style.visibility = "collapse";
}
if (this.status === 404) {
document.getElementById("result").innerHTML = "<div id='message' style='margin-top:10px;'>User does not exist on GitHub :(</div>";
document.getElementById("show").style.visibility = "collapse";
}
};
req.onerror = function() {
reject(Error("Network Error"));
Expand All @@ -143,10 +147,10 @@ function initData(handle) {
{ lastSearched: handle, thumbnail: avatarUrl },
function() {
var res = "";
res += `<div id='resultHandle'>${handle}s progress:</div>`;
var showS = handle[handle.length - 1] !== 's';
res += `<div id='resultHandle'>${handle}'${showS ? 's' : ''} progress:</div>`;
var count = (prCount > 5 ? "5" : prCount) + " / 5";
var progress = prCount * 20;
// res += ``;
res += `<div class='progress-bar'><div id='prCompleteCount'>${count}</div><div class='progress-bar--color' style='width:${progress}%'></div></div>`
var message = getMessage(prCount);
res += `<div id='message'>${message}</div>`;
Expand Down