Modify TreeDataGrid to use column.frozen value if present
#3417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasilgeo
force-pushed
the
feat/use-column-frozen-prop-for-tree-data-grid
branch
from
965337f to
a213ad4
Compare
jwasilgeo
force-pushed
the
feat/use-column-frozen-prop-for-tree-data-grid
branch
from
c2e0f19 to
4fd6e03
Compare
added 2 commits
February 11, 2024 21:42
jwasilgeo
force-pushed
the
feat/use-column-frozen-prop-for-tree-data-grid
branch
from
4fd6e03 to
87f698d
Compare
| @@ -96,7 +96,7 @@ function TreeDataGrid<R, SR, K extends Key>( | |||
| groupBy.push(column.key); | |||
| columns[index] = { | |||
| ...column, | |||
| frozen: true, | |||
| frozen: column.frozen ?? true, | |||
There was a problem hiding this comment.
What happens if the data is grouped on two columns and only the first column has frozen: false?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello maintainers 👋. I'd like to introduce the ability to toggle on/off frozen group columns in the
TreeDataGrid. Please let me know if there is anything else I can do in this PR to make it ready for review and your consideration to merge in to this library. Thanks!This PR:
TreeDataGridto rely oncolumn.frozenvalues if present, rather than being hard-coded totruealways.RowGroupinglive demo to demonstrate this functionality with a checkbox to toggle it on/off for the grouping columns.Screen.Recording.2024-01-04.at.9.56.41.AM.mov