[pull] main from electron:main#501
Merged
pull[bot] merged 3 commits intoadamlaska:mainfrom Apr 15, 2026
Merged
Conversation
* ci: allow manual backports to pass template check Co-Authored-By: Claude <noreply@anthropic.com> Generated-By: GitHub Copilot * Update .github/workflows/pr-template-check.yml Co-authored-by: Niklas Wenzel <dev@nikwen.de> --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Niklas Wenzel <dev@nikwen.de>
* refactor: migrate electron::api::GlobalShortcut to cppgc * refactor: lazy-create electron::api::GlobalShortcut copy the lazy-create idom used by electron::api::Screen * refactor: use gin::WeakCellFactory in GlobalCallbacks * fix: make a copy of `callback` before running it safeguard against the callback changing the map, invalidating `cb` * chore: reduce unnecessary diffs with main * fixup! refactor: use gin::WeakCellFactory in GlobalCallbacks fix: must Trace() the weak cell factory * fix: destruction order - Setup isolate dispose observer to run destruction sequences and remove self persistent reference - Skip NOTREACHED check during destruction, it can happen as a result of plaform listeners scheduling callbacks when Unregister is invoked. - Fix the order of unregistration in GlobalShortcut::Unregister - Add GlobalShortcut::UnregisterAllInternal to avoid any callsites that can re-enter V8 * fix: crash during gc from incorrect cppgc object headers * chore: update patches * chore: cleanup * chore: fix lint --------- Co-authored-by: deepak1556 <hop2deep@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )