Add Folders to ZipArchive#342
Open
dos-ise wants to merge 3 commits intoadamhathcock:masterfrom
dos-ise:AddFolders
Open
Add Folders to ZipArchive#342dos-ise wants to merge 3 commits intoadamhathcock:masterfrom dos-ise:AddFolders
dos-ise wants to merge 3 commits intoadamhathcock:masterfrom
dos-ise:AddFolders
Conversation
Owner
adamhathcock
left a comment
adamhathcock
left a comment
There was a problem hiding this comment.
Why so this over using the existing extension methods?
Author
|
You mean the AddAllFromDirectory Extension? Its a behavior from dotnetzip we use quit alot. |
Owner
|
I couldn't quite tell what you were going for. So you want the ability to add directory entries? |
Author
|
Correct, I added a test to clarify for what I am trying to achieve. Sorry for the misleading commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Folders to ZipArchive like in dotnetzip. Not yet ready