[codex] Fix Windows TUI key handling - #8
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughShort-circuits keyboard release events in the TUI: Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
adambuchweitz
force-pushed
the
codex/fix-windows-tui-key-release
branch
2 times, most recently
from
April 13, 2026 21:09
7b5985b to
b2e8a1b
Compare
adambuchweitz
marked this pull request as ready for review
April 14, 2026 14:32
adambuchweitz
force-pushed
the
codex/fix-windows-tui-key-release
branch
from
April 14, 2026 16:18
5a98cfa to
c95060e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes duplicated key handling in the TUI Manager on Windows.
What changed
crosstermKeyEventKind::Releaseevents before dispatching Manager inputTabfield navigationWhy
On Windows,
crosstermreports key release events, and the Manager was treating them the same as actual key presses. That caused characters to be inserted twice andTabto advance twice.Validation
cargo testSummary by CodeRabbit
Bug Fixes
New Features
Tests
Chores