fix: prevent installer using stale files

[adambuchweitz]

Summary by CodeRabbit

• Chores
  • Updated build instructions for Arch packages and improved cleanup of previous build artifacts.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d0b7dfe3-e6b1-48a4-8e69-199ecdb5a1d7

📥 Commits

Reviewing files that changed from the base of the PR and between fd8f5dd and f2993ff.

📒 Files selected for processing (1)

• scripts/build-arch-package.sh

---

📝 Walkthrough

Walkthrough

The build-arch-package.sh script now enables nullglob to safely construct arrays of existing package artifacts, deletes those files along with the generated PKGBUILD and tar archive during the cleanup phase, and updates the user-facing instruction to run makepkg -Csi instead of makepkg -f.

Changes

Cohort / File(s)	Summary
Build Script Cleanup scripts/build-arch-package.sh	Added nullglob option to safely glob and delete previously built package files (${package_name}-*.pkg.tar*, ${package_name}-debug-*.pkg.tar*), existing tar archive, and generated PKGBUILD. Updated the "Next steps" instruction from makepkg -f to makepkg -Csi.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: prevent installer using stale files' directly and clearly describes the main change: preventing the installer from using outdated/stale package files by deleting them during the build process.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-installer

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}