[Fix] Implement version check for FruitJam C6 #844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This has been tested on an Adafruit Fruit Jam running nina-fw v3.2.0 (latest) |
tyeth
approved these changes
Dec 2, 2025
Member
tyeth
left a comment
tyeth
left a comment
There was a problem hiding this comment.
LGTM. Will have a go at the upgrade/test tomorrow.
Member
Author
|
@tyeth Do you want me to hold off merging this until you test? |
Member
|
No, not at all. It looks good, minimal repercussions.
It might be worth altering the bootlog.txt message to disambiguate better
between the Wippersnapper FW version and Airlift version, as we did have
one user mention confusion in the forums.
I was thinking we could change it to something like "AirLift WiFi
coprocessor version:" or something like that. It isn't currently helped
that the WipperSnapper version doesn't mention it's firmware but airlift
does.
…On Tue, 2 Dec 2025 at 21:31, Brent Rubell ***@***.***> wrote:
*brentru* left a comment (adafruit/Adafruit_Wippersnapper_Arduino#844)
<#844 (comment)>
@tyeth <https://github.com/tyeth> Do you want me to hold off merging this
until you test?
—
Reply to this email directly, view it on GitHub
<#844 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTBZ47MBNXNM2IC5F4WHL337YAKPAVCNFSM6AAAAACN22HKQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMBUGA2TEOBTHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds guards and nina-fw version check for FruitJam (adafruit/nina-fw#75) which has issues with TCP sockets on older nina-fw versions.