suppress clang-tidy warnings re: Annex K functions
#983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suppress clang-tidy's insecureAPI.DeprecatedOrUnsafeBufferHandling
check, which produces false positives for functions like fprintf().
Further, this check recommends adoption of C11 Annex K functions that
are unavailable under many libc's (including glibc) and controversial
amongst experts.
For additional background:
https://www.open-std.org/jtc1/sc22/wg14/www/docs/n1969.htm
https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2336.pdf
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88700
https://gcc.gnu.org/pipermail/gcc/2019-December/231070.html
llvm/llvm-project#64027
lemire
approved these changes
Jul 23, 2025
anonrig
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick follow-up to #981
Suppress clang-tidy's
clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandlingcheck, which produces false positives for functions likefprintf(). Further, this check recommends adoption of C11 Annex K functions that are unavailable under many libc's (including glibc) and controversial amongst experts.Apologies for not including this as part of #981. I only realized after merging that although this check does not currently generate false positives on the ada codebase, it would be confusing for contributors to have future PRs blocked because of innocent/innocuous use of functions like
fprintf()andmemset().For additional background: