CMake Native HIP Usage, main branch (2026.02.18.)#352
Merged
krasznaa merged 2 commits intoacts-project:mainfrom Feb 19, 2026
Merged
CMake Native HIP Usage, main branch (2026.02.18.)#352krasznaa merged 2 commits intoacts-project:mainfrom
krasznaa merged 2 commits intoacts-project:mainfrom
Conversation
krasznaa
force-pushed
the
CMakeNativeHIP-main-20260218
branch
from
5decdbe to
6329e3e
Compare
Switching to rathr building HIP code using CMake's built-in functionality. Which is implemented scarily similarly to how this project's code behaved.
krasznaa
force-pushed
the
CMakeNativeHIP-main-20260218
branch
from
6329e3e to
6258653
Compare
|
Member
Author
|
Relatively simple tests on our standard AMD test machine seem to work fine with this. Including its ability to still build the HIP code for an NVIDIA backend. Let's cross fingers, and move ahead with this... 🤞 |
This was referenced Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my alternative suggestion to #342.
@StewMH, I ran some tests. At least with the (close to) latest CMake version I was able to compile code using CMake's built-in HIP support for an NVIDIA backend as well. The CMake code even respects the
HIP_PLATFORMenvironment variable for giving a default value to CMAKE_HIP_PLATFORM. Even though the documentation doesn't mention that anywhere. (As far as I could see.) Which mirrors how this project's code currently behaves.UBSAN I also bumped into as an issue, but I think I found a more robust way to turn it off when it's not available. 🤔
All in all, while I'll still need to so some further tests on a native AMD system as well, I think the time may indeed be here finally to retire the custom HIP code of the project. 😉