HIP/SYCL CMake Code Visibility, main branch (2026.02.18.)#351
Merged
krasznaa merged 1 commit intoacts-project:mainfrom Feb 19, 2026
Merged
HIP/SYCL CMake Code Visibility, main branch (2026.02.18.)#351krasznaa merged 1 commit intoacts-project:mainfrom
krasznaa merged 1 commit intoacts-project:mainfrom
Conversation
krasznaa
force-pushed
the
CMakeFix-main-20260218
branch
from
f4f2611 to
4180ea5
Compare
|
Contributor
|
I haven't tried using the NVidia backend for HIP yet. #342 depends on the quality of the native support for HIP: seems fine for me with cmake 4.0.1. No objections to this, it might indeed help with acts-project/traccc#1211 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported by @StewMH in https://its.cern.ch/jira/browse/ATEAM-1138 (which I'm now working around in https://gitlab.cern.ch/atlas/athena/-/merge_requests/86180), clients trying to use this project's SYCL (or HIP) building functionality from a pre-installed version of VecMem, have not worked for a while. 😦
I was trying to find the exact PR in which this was broken, but gave up after a while...
I'm interested in your opinion Stewart: I believe this issue also has to do with why you have seen a bit different of a behaviour with your HIP build from what I've seen. 🤔 Now that since CMake 3.28 we can technically build HIP code for NVIDIA backends with native CMake as well, I guess this addition may just make your life even harder, doesn't it...?
Still, I would probably first put this in, and then finally look at #342. (Which will need some tweaking.)