Skip to content

refactor: Move jet class from plugins to EventData, remove FastJet as plugin#5089

Merged
kodiakhq[bot] merged 19 commits intoacts-project:mainfrom
delitez:freeJetClass
Feb 18, 2026
Merged

refactor: Move jet class from plugins to EventData, remove FastJet as plugin#5089
kodiakhq[bot] merged 19 commits intoacts-project:mainfrom
delitez:freeJetClass

Conversation

@delitez
Copy link
Contributor

@delitez delitez commented Feb 11, 2026

In this PR, the Jet class is moved to EventData and no longer depends on FastJet. This makes the Jet class more general and removes the need for a FastJet dependency in TruthJetContainer for future use. With this change, the FastJet dependency is confined to TruthJetAlgorithm, and FastJet is no longer a Plugin.

--- END COMMIT MESSAGE ---

Thanks for the suggestion @benjaminhuth

@github-actions github-actions bot added Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Event Data Model labels Feb 11, 2026
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for implementing this! There are a couple of namespace declarations that could be removed, but not at all critical.

One question for clarification: With this, we remove the FastJet Plugin entirely, right? Would be good to mention this in the PR title and description.

@github-actions github-actions bot added this to the next milestone Feb 11, 2026
@delitez delitez changed the title refactor: Move jet class from plugins to EventData refactor: Move jet class from plugins to EventData, remove FastJet as plugin Feb 11, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

📊: Physics performance monitoring for 4c3155c

Full contents

physmon summary

@github-actions github-actions bot added the Component - Documentation Affects the documentation label Feb 11, 2026
@delitez delitez marked this pull request as ready for review February 11, 2026 10:40
@paulgessinger
Copy link
Member

The main CMakeLists.txt still needs some cleanup here, the plugin option is still there, and we probably want an option then to turn the examples-level fastjet code on and off, so that enabling the examples doesn't necessarily require having fastjet available.

@delitez
Copy link
Contributor Author

delitez commented Feb 13, 2026

The main CMakeLists.txt still needs some cleanup here, the plugin option is still there, and we probably want an option then to turn the examples-level fastjet code on and off, so that enabling the examples doesn't necessarily require having fastjet available.

With the latest commit, I removed plugin option and introduced examples-fastjet option.

@sonarqubecloud
Copy link

@kodiakhq kodiakhq bot merged commit 48dd530 into acts-project:main Feb 18, 2026
42 checks passed
@delitez delitez deleted the freeJetClass branch February 18, 2026 11:46
@andiwand andiwand modified the milestones: next, v45.2.0 Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component - Documentation Affects the documentation Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Event Data Model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants