Skip to content

Conversation

digitaldina
Copy link

@digitaldina digitaldina commented May 21, 2025

Contributor checklist


Description

  • Added fixture for authenticated request using Django's REST Framework's force_authenticate function by changing conftest.py
  • Added test using fixture in backend/authentication/tests/test_auth.py

Related issue

Copy link

netlify bot commented May 21, 2025

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit ec13aec
🔍 Latest deploy log https://app.netlify.com/projects/activist-org/deploys/687e6a2e7082c60008731f41
😎 Deploy Preview https://deploy-preview-1280--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Thank you for the pull request! ❤️

The activist team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider attending our bi-weekly Saturday developer syncs! It'd be great to meet you 😊

Copy link
Contributor

github-actions bot commented May 21, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The TypeScript, pytest and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo (can be set with git config --global user.email "GITHUB_EMAIL")

@andrewtavis andrewtavis requested review from andrewtavis and to-sta May 21, 2025 13:10
@andrewtavis
Copy link
Member

Thanks, @digitaldina! We'll get to the review in the coming days :) Can you write in #1270 so we can assign you? 😊

@to-sta
Copy link
Collaborator

to-sta commented May 25, 2025

@digitaldina tried running your tests but the fixture was not available in the tests. We had the conftest.py file in the location, I am moved it to the root of the backend directory.

Your fixture is availabe now to all tests 😃.

@andrewtavis
Copy link
Member

From here @digitaldina, if you could fix the tests that are failing, and then from there we can we can make these changes in each of the places that we have # Login to get token. :)

@to-sta
Copy link
Collaborator

to-sta commented Jun 9, 2025

Hi @digitaldina, are you still working on this PR? I reviewed your tests and noticed that some of the endpoints being used don’t exist, for example:

  • "/v1/auth/user/"
  • "/v1/auth/profile/"

You can find the complete list of exposed endpoints in SwaggerUI. Let me know if you need help locating anything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants