-
Notifications
You must be signed in to change notification settings - Fork 374
Fix for #1270, Added fixture for authenticated requests #1280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Thank you for the pull request! ❤️The activist team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First PR Commit Check
- The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.email
in their local activist repo (can be set withgit config --global user.email "GITHUB_EMAIL"
)
Thanks, @digitaldina! We'll get to the review in the coming days :) Can you write in #1270 so we can assign you? 😊 |
@digitaldina tried running your tests but the fixture was not available in the tests. We had the Your fixture is availabe now to all tests 😃. |
From here @digitaldina, if you could fix the tests that are failing, and then from there we can we can make these changes in each of the places that we have |
Hi @digitaldina, are you still working on this PR? I reviewed your tests and noticed that some of the endpoints being used don’t exist, for example:
You can find the complete list of exposed endpoints in SwaggerUI. Let me know if you need help locating anything! |
Contributor checklist
Description
Related issue