fix(ci): use the GitHub App client ID#8
Merged
Conversation
Summary: - switch the deployment token action to its supported client-id input - document and lint the new repository variable name Rationale: - remove the remaining deprecated app-id input warning - retain the existing App installation and private-key credential Tests: - COLUMNS=240 LINES=60 make -C elixir all - actionlint -config-file .github/actionlint.yaml Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The Node 24 upgrades removed the runtime warnings, but the deployment dispatch still warns that the GitHub App action's
app-idinput is deprecated.TL;DR
Use the existing GitHub App client ID through the supported action input.
Summary
app-idwithclient-idwhen minting the deployment token.SYMPHONY_DEPLOY_CLIENT_IDrepository variable.Alternatives
Test Plan
COLUMNS=240 LINES=60 make -C elixir allactionlint -config-file .github/actionlint.yaml