Skip to content

Conversation

@jgrayson676
Copy link
Contributor

Description of the change

Because the Authorization header is already in use, I opted to stick the token in a custom header

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change
  • Technical Debt
  • Documentation

Related tickets

https://app.shortcut.com/active-prospect/story/87918/send-cpl-data-to-trustedform

Checklists

Development and Testing

  • Lint rules pass locally.
  • The code changed/added as part of this pull request has been covered with tests, or this PR does not alter production code.
  • All tests related to the changed code pass in development, or tests are not applicable.

Code Review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • At least two engineers have been added as "Reviewers" on the pull request.
  • Changes have been reviewed by at least two other engineers who did not write the code.
  • This branch has been rebased off master to be current.

Tracking

  • Issue from Shortcut/Jira has a link to this pull request.
  • This PR has a link to the issue in Shortcut.

QA

  • This branch has been deployed to staging and tested.

@jgrayson676 jgrayson676 requested a review from cgrayson April 8, 2025 14:56

if(process.env.TRUSTEDFORM_CPL_TOKEN) {
headers['CPL-Token'] = process.env.TRUSTEDFORM_CPL_TOKEN;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the value should probably be masked (like the TRUSTEDFORM_DATA_SERVICE_TOKEN in insights.js), right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had thought that masking was updated to apply to all environment variables by default, but I'll double check that that's the case

@jgrayson676 jgrayson676 requested a review from cgrayson April 8, 2025 20:01
cgrayson
cgrayson previously approved these changes Apr 8, 2025
Copy link
Contributor

@cgrayson cgrayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jgrayson676 jgrayson676 merged commit 21eb60f into master Apr 24, 2025
3 checks passed
@jgrayson676 jgrayson676 deleted the sc-87918/send-cpl-data-to-trustedform branch April 24, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants